Factor out ID printing code into common.c#38
Merged
keithbusch merged 1 commit intolinux-nvme:masterfrom Dec 3, 2015
pmmccorm:master
Merged
Factor out ID printing code into common.c#38keithbusch merged 1 commit intolinux-nvme:masterfrom pmmccorm:master
keithbusch merged 1 commit intolinux-nvme:masterfrom
pmmccorm:master
Conversation
The printing output should be identical. The id structure printing functions can be more or less used by lsnvme. Signed-off-by: Patrick McCormick <patrick.m.mccormick@intel.com>
Contributor
|
Looks fairly uncontroversial to me, though I think we should prefer flags defined as an enum. Do you have a planned usage for the terse flag? |
Contributor
Author
|
I actually had flags defined as an enum and then changed it. I can change it back. For terse I was thinking: Something like that. |
Contributor
Author
|
Updated with enum change. |
keithbusch
pushed a commit
that referenced
this pull request
Dec 3, 2015
Factor out ID printing code into common.c
ikegami-t
pushed a commit
to ikegami-t/nvme-cli
that referenced
this pull request
Aug 18, 2023
Fix bug in `nvme_identify_iocs`
jimmunn
pushed a commit
to Micron-TPG-OSS/nvme-cli
that referenced
this pull request
Feb 23, 2026
…inux-nvme#38) * Merge origin/master into mingw * Initial plan * Fix circular dependency in platform_linux.h by removing cleanup.h include Co-authored-by: bbusacker_micron <199673931+bbusacker_micron@users.noreply.github.com> * use the code base standard for initializing variables --------- Co-authored-by: Brandon Capener <bcapener@micron.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bbusacker_micron <199673931+bbusacker_micron@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The printing output should be identical. The id structure
printing functions can be more or less used by lsnvme.
Signed-off-by: Patrick McCormick patrick.m.mccormick@intel.com