{Makefile,util.c}: fix build on musl / uClibc-ng #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsyslog() is not in POSIX, so only exposed by <syslog.h> on musl and uclibc-ng if we define _DEFAULT_SOURCE. https://git.musl-libc.org/cgit/musl/tree/include/syslog.h#n64 https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/tree/include/sys/syslog.h#n200 While we are at it, drop the glibc-implementation-specific __USE_MISC define in src/util.c to get rid of a double definition: src/util.c:3: warning: "__USE_MISC" redefined 3 | #define __USE_MISC | In file included from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33, from /usr/include/stdio.h:27, from src/util.c:2: /usr/include/features.h:395: note: this is the location of the previous definition 395 | # define __USE_MISC 1 On glibc (and uClibc-ng) the internal __USE_MISC symbol gets defined if _DEFAULT_SOURCE is: https://github.com/bminor/glibc/blob/master/include/features.h#L417-L419 Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
|
+1 fixes issues with the build in buildroot against uclibc/musl |
Member
|
Thank you for your contribution @jacmet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vsyslog() is not in POSIX, so only exposed by <syslog.h> on musl and uclibc-ng if we define _DEFAULT_SOURCE.
https://git.musl-libc.org/cgit/musl/tree/include/syslog.h#n64 https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/tree/include/sys/syslog.h#n200
While we are at it, drop the glibc-implementation-specific __USE_MISC define in src/util.c to get rid of a double definition:
On glibc (and uClibc-ng) the internal __USE_MISC symbol gets defined if _DEFAULT_SOURCE is:
https://github.com/bminor/glibc/blob/master/include/features.h#L417-L419