⚙️ FEATURE-#20: Dedupe Email.from_email / EmailFactories.from_address#25
Merged
Conversation
48b936f to
fa4f91c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20
Summary
Email.from_emailandEmailFactories.from_addresswere both callingresolve_imap_hostand packing the result manually — two sources of truth for the same operation.This PR keeps
EmailFactories.from_addressas the single implementation and reroutesEmail.from_emailthrough it.Diff
Top-level import of
resolve_imap_hostinemail.pyis removed (no longer needed).Test fix
tests/test_email.py::TestFromEmail::test_uses_resolvernow patchesemail_profile.factories.resolve_imap_host(the real call site) instead ofemail_profile.email.resolve_imap_host.Test plan