Skip to content

Split validate_status into validate and check for clarity#61

Merged
FernandoCelmer merged 1 commit into
developfrom
feature/39
Apr 16, 2026
Merged

Split validate_status into validate and check for clarity#61
FernandoCelmer merged 1 commit into
developfrom
feature/39

Conversation

@FernandoCelmer
Copy link
Copy Markdown
Member

Summary

  • Removed the confusing raise_error parameter from validate_status() β€” it now always raises on error (the common case)
  • Added a new check_status() method that returns a StatusResponse without raising, for callers that need to inspect the result
  • Updated the test that used raise_error=False to use check_status() instead

Closes #39

Test plan

  • All 149 existing tests pass
  • Pre-commit hooks (ruff lint/format) pass

@FernandoCelmer
Copy link
Copy Markdown
Member Author

πŸ” Code Review β€” No issues found. LGTM, safe to merge.

@FernandoCelmer FernandoCelmer merged commit c6aa637 into develop Apr 16, 2026
11 checks passed
@FernandoCelmer FernandoCelmer deleted the feature/39 branch April 16, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant