Build system improvements#21
Merged
Merged
Conversation
| @@ -0,0 +1,11 @@ | |||
| prefix=@prefix@ | |||
| exec_prefix=@exec_prefix@ | |||
| libdir=#libdir@ | |||
Contributor
There was a problem hiding this comment.
Thanks for improving the build, a minor nit-pick libdir=#libdir@ should be libdir=@libdir@
Contributor
Author
There was a problem hiding this comment.
Ah! Thanks, fixed now, seems I missed that when checking the generated output. :)
The .pc are a better replacement for library detection and linking usage, than libtool .la files or hardcoding the flags in the using code.
Use the generic automake silent prefix macros for this file.
These are unit tests which should not end up installed on the system, and should not be built as part of «make all». These will be built as part of «make check» instead. Ideally they would also be executed as part of the test suite, but they currently depend on the host systems' sysfs.
guillemj
force-pushed
the
pu/build-sys
branch
from
1aa829d to
312c0e1
Compare
In out-of-tree builds the current directory is the build directory which is different to the source directory. As a consequence this also fixes «make distcheck» to work.
guillemj
force-pushed
the
pu/build-sys
branch
from
312c0e1 to
81c3e01
Compare
kamalesh-babulal
approved these changes
Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a libsysfs.pc file, derived from the one used in Debian for pkg-config use. Fixes a silent rule for test.h. Moves the unit tests into a more appropriate automake variable. Fixes out-of-tree build support.