Perftest: Fix specifying QP number 1 in non bw test #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Yue-ByteDance i think it would be clearer to change the condition to |
Original message says that multiple QPs is only available for bw test, but even if user uses `-q 1`, it would still fail and print error, which doesn't match with the message. Change the logic to check if user specified more than 2 QPs for non-bw tests. Signed-off-by: yuezelong <yuezelong@bytedance.com>
Yue-ByteDance
force-pushed
the
yzl/change-error-msg
branch
from
9dccf8f to
a07e85a
Compare
Yue-ByteDance
changed the title
Contributor
Author
Hello, I've updated the commit according to your suggestion, thanks! |
Contributor
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original message says that multiple QPs is only available for bw test, but even if user uses
-q 1, it would still fail and print error, which doesn't match with the message. Change that message to a clearer expression.