Perftest: add has_recv_comp() inline helper for verb type checks#374
Merged
sshaulnv merged 1 commit intolinux-rdma:masterfrom Mar 15, 2026
Merged
Perftest: add has_recv_comp() inline helper for verb type checks#374sshaulnv merged 1 commit intolinux-rdma:masterfrom
sshaulnv merged 1 commit intolinux-rdma:masterfrom
Conversation
Contributor
|
@Yue-ByteDance , looks great, can you please rebase and i will merge it? |
Multiple places across perftest_parameters.c and perftest_resources.c check whether a verb generates receive-side completions using the compound condition: verb == SEND || verb == SEND_IMM || verb == WRITE_IMM This pattern is repeated multiple times across the codebase, making it error-prone to maintain and easy to get wrong when adding new code paths. Introduce a static inline helper `has_recv_comp()` in perftest_parameters.h and convert the call sites in perftest_parameters.c and perftest_resources.c to use it. Signed-off-by: Zelong Yue <yuezelong@bytedance.com>
Yue-ByteDance
force-pushed
the
yzl/inline-helper
branch
from
586c356 to
c201134
Compare
Contributor
Author
|
Thanks! Just rebased. |
Contributor
|
merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple places across perftest_parameters.c and perftest_resources.c check whether a verb generates receive-side completions using the compound condition:
verb == SEND || verb == SEND_IMM || verb == WRITE_IMM
This pattern is repeated multiple times across the codebase, making it error-prone to maintain and easy to get wrong when adding new code paths.
Introduce a static inline helper
has_recv_comp()in perftest_parameters.h and convert the call sites in perftest_parameters.c and perftest_resources.c to use it.