Perftest: propagate --use_hugepages to RDMA CM connections#375
Merged
sshaulnv merged 1 commit intolinux-rdma:masterfrom Mar 16, 2026
Merged
Perftest: propagate --use_hugepages to RDMA CM connections#375sshaulnv merged 1 commit intolinux-rdma:masterfrom
sshaulnv merged 1 commit intolinux-rdma:masterfrom
Conversation
RDMA CM connection setup currently ignores the `--use_hugepages` flag because `rdma_params->use_hugepages` is never populated from user_param. This makes RDMA CM behavior inconsistent with the out-of-band path. Copy `user_param->use_hugepages` into `comm->rdma_params->use_hugepages` during `create_comm_struct()` so memory allocation/registration honors the CLI option for both connection modes. Signed-off-by: Zelong Yue <yuezelong@bytedance.com>
Contributor
|
thanks for the PR, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDMA CM connection setup currently ignores the
--use_hugepagesflag becauserdma_params->use_hugepagesis never populated from user_param. This makes RDMA CM behavior inconsistent with the out-of-band path.Copy
user_param->use_hugepagesintocomm->rdma_params->use_hugepagesduringcreate_comm_struct()so memory allocation/registration honors the CLI option for both connection modes.