ci: Show exceptions in Ansible logs#103
Merged
richm merged 1 commit intolinux-system-roles:mainfrom May 1, 2025
Merged
Conversation
Sometimes tests fail with "An exception occurred during task execution." instead of "fatal:". Catch this case as well.
4 tasks
richm
reviewed
Apr 24, 2025
| set -euo pipefail | ||
| for f in tests/*.log; do | ||
| if FAIL=$(grep -B100 -A30 "fatal:" "$f"); then | ||
| if FAIL=$(grep -E -B100 -A30 "fatal:|An exception occurred" "$f"); then |
Contributor
There was a problem hiding this comment.
https://github.com/linux-system-roles/auto-maintenance/blob/main/check_logs.py#L253 get_errors_from_ansible_log does this and more. We just need to add an option to check_logs.py to print the ansible errors in a 'github action' friendly way.
richm
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes tests fail with "An exception occurred during task execution." instead of "fatal:". Catch this case as well.
Spotted in linux-system-roles/cockpit#212 where the initial run didn't show the actual failure of tests_port2.yml. I added this commit to that PR as well, and the new run with that commit shows the proper error.