ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

In order to ensure that commits and PRs conform to this, use
ANSIBLE_INJECT_FACT_VARS=false by default in our CI testing.

Update README-ostree.md if needed.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Adopt Ansible's non-injected facts usage in CI and documentation to prepare for upcoming deprecations.

CI:

• Set ANSIBLE_INJECT_FACT_VARS=false in GitHub Actions integration tests and TFT workflow to align CI runs with Ansible 2.20+ behavior.

Documentation:

• Update README-ostree to reference ansible_facts["distribution"] and ansible_facts["distribution_version"] instead of deprecated fact variables.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Configures CI to run Ansible tests with fact injection disabled and updates documentation to reference the new ansible_facts-based variables instead of deprecated fact vars.

Sequence diagram for CI Ansible test run with ANSIBLE_INJECT_FACT_VARS disabled

sequenceDiagram
  title CI Ansible test run with ANSIBLE_INJECT_FACT_VARS disabled
  actor Developer
  participant GitHubActions
  participant TFTWorkflow
  participant SystemRolesTests
  participant AnsibleEngine

  Developer->>GitHubActions: Open PR / push commit
  GitHubActions->>GitHubActions: Trigger tft workflow job
  GitHubActions->>TFTWorkflow: Start job with env (SR_ANSIBLE_INJECT_FACT_VARS=false)
  TFTWorkflow->>SystemRolesTests: Run tests with SR_ANSIBLE_INJECT_FACT_VARS=false
  SystemRolesTests->>AnsibleEngine: Execute playbooks with INJECT_FACTS_AS_VARS=false
  AnsibleEngine-->>SystemRolesTests: Use ansible_facts based variables
  SystemRolesTests-->>TFTWorkflow: Report test results
  TFTWorkflow-->>GitHubActions: Exit status
  GitHubActions-->>Developer: CI status on PR

Loading

File-Level Changes

Change	Details	Files
Update ostree README to reference ansible_facts keys instead of deprecated fact variables.	Replace documentation references to ansible_distribution with ansible_facts["distribution"] Replace documentation references to ansible_distribution_version with ansible_facts["distribution_version"]	README-ostree.md
Ensure GitHub Actions Ansible-based integration tests run with fact injection disabled.	Set ANSIBLE_INJECT_FACT_VARS=false in the qemu-kvm-integration-tests workflow env block to match Ansible 2.20+ behavior Pass SR_ANSIBLE_INJECT_FACT_VARS=false through Terraform in the tft workflow so downstream jobs also run with fact injection disabled	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/tft.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In the workflows, qemu-kvm-integration-tests sets ANSIBLE_INJECT_FACT_VARS directly while tft.yml passes SR_ANSIBLE_INJECT_FACT_VARS; consider standardizing how this is wired through (or adding a brief inline note) so it's clear where the actual ANSIBLE_INJECT_FACT_VARS environment variable is ultimately set for Ansible.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In the workflows, `qemu-kvm-integration-tests` sets `ANSIBLE_INJECT_FACT_VARS` directly while `tft.yml` passes `SR_ANSIBLE_INJECT_FACT_VARS`; consider standardizing how this is wired through (or adding a brief inline note) so it's clear where the actual `ANSIBLE_INJECT_FACT_VARS` environment variable is ultimately set for Ansible.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}