Skip to content

ci: Onboard HPC role#3

Merged
spetrosi merged 1 commit intomainfrom
hpc-onboard
Jul 17, 2025
Merged

ci: Onboard HPC role#3
spetrosi merged 1 commit intomainfrom
hpc-onboard

Conversation

@spetrosi
Copy link
Collaborator

@spetrosi spetrosi commented Jul 17, 2025

Signed-off-by: Sergei Petrosian spetrosi@redhat.com

Summary by Sourcery

Onboard the HPC system role by replacing template references with HPC equivalents, updating documentation and CI workflows, renaming internal variables, and adding local CI test instructions.

New Features:

  • Add instructions in contributing.md for running CI tests locally using tox-lsr and QEMU

Enhancements:

  • Rename all role references and links from 'template' to 'hpc' across docs, workflows, and README badges
  • Update variable prefixes from _template* to _hpc* in vars and test definitions
  • Update tft.yml test plan filter tag from 'template' to 'hpc'
  • Bump tox-lsr version from 3.11.0 to 3.11.1 in CI workflows
  • Adjust the weekly_ci workflow cron schedule

CI:

  • Update CI workflows to install tox-lsr@3.11.1 and modify test plan tags and schedule

Documentation:

  • Expand contributing.md with setup steps and CI testing guidelines
  • Update plans/README-plans.md and README.md to reference HPC repository paths and workflows

Signed-off-by: Sergei Petrosian <spetrosi@redhat.com>
@spetrosi spetrosi self-assigned this Jul 17, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Jul 17, 2025

Reviewer's Guide

This PR onboards the new HPC Linux System Role by forking and customizing the template role: project references and documentation are updated to “hpc”, distribution variable names are renamed, CI instructions are expanded, and GitHub workflow configurations are adjusted for the new role.

Class diagram for renamed distribution variables in HPC role

classDiagram
  class HPCVars {
    +list __hpc_rh_distros
    +list __hpc_rh_distros_fedora
    +bool __hpc_is_rh_distro
    +bool __hpc_is_rh_distro_fedora
  }

  HPCVars : __hpc_rh_distros = [AlmaLinux, CentOS, RedHat, Rocky]
  HPCVars : __hpc_rh_distros_fedora = __hpc_rh_distros + [Fedora]
  HPCVars : __hpc_is_rh_distro = ansible_distribution in __hpc_rh_distros
  HPCVars : __hpc_is_rh_distro_fedora = ansible_distribution in __hpc_rh_distros_fedora
Loading

File-Level Changes

Change Details Files
Project references and documentation updated for the new hpc role
  • Replaced ‘template’ with ‘hpc’ in contributing guidelines and GitHub URLs
  • Added a new section on running CI tests locally with tox-lsr and QEMU
  • Updated Testing Farm plan docs to point at the hpc repository
  • Refreshed README badges to reference hpc workflows
contributing.md
plans/README-plans.md
README.md
Renamed Ansible distribution variable prefixes to __hpc
  • Changed all _template* distro variables to _hpc* in test vars
  • Updated corresponding conditionals for RHEL and Fedora distributions
tests/vars/rh_distros_vars.yml
vars/main.yml
CI workflows adjusted for hpc role and tox-lsr version bump
  • Bumped tox-lsr dependency from 3.11.0 to 3.11.1 in multiple workflows
  • Updated tmt_plan_filter to include ‘hpc’ tag instead of ‘template’
  • Modified weekly CI cron schedule timing
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
.github/workflows/qemu-kvm-integration-tests.yml
.github/workflows/tft.yml
.github/workflows/weekly_ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @spetrosi - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@spetrosi spetrosi merged commit 7433759 into main Jul 17, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant