Conversation
…on to v4; bump upload-artifact to v5 use versioned upload-artifact instead of master bump codeql-action from v3 to v4 bump upload-artifact from v4 to v5 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR ensures deterministic CI behavior by pinning GitHub Actions to specific versions: it updates the CodeQL scanning action to v4 and replaces master references in the upload-artifact action with the v5 tag across the repository’s workflows. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Your description mentions bumping codeql-action to v4 but I don’t see any changes to the CodeQL workflows—please update those files if that was intended.
- Double-check that all workflows consistently reference upload-artifact@v5, as there may be other scripts or jobs still pointing at master.
- Consider pinning to a specific sub-version (e.g., v5.0.x) instead of the floating v5 tag to avoid unexpected breaking changes in future minor releases.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Your description mentions bumping codeql-action to v4 but I don’t see any changes to the CodeQL workflows—please update those files if that was intended.
- Double-check that all workflows consistently reference upload-artifact@v5, as there may be other scripts or jobs still pointing at master.
- Consider pinning to a specific sub-version (e.g., v5.0.x) instead of the floating v5 tag to avoid unexpected breaking changes in future minor releases.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use versioned upload-artifact instead of master
bump codeql-action from v3 to v4
bump upload-artifact from v4 to v5
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Use versioned GitHub Actions by updating upload-artifact to v5 and CodeQL action to v4 in CI workflows
CI: