test: do not install moneo

[richm]

Do not install moneo in tests - requires special image

Fix indentation

Move tests/test.yml to tests/playbooks directory because it is a playbook
but it isn't a test that we want to run in CI.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Adjust SKU customisation task structure and update tests to avoid installing moneo in default scenarios.

Bug Fixes:

• Correct a typo in a test comment to clarify intended behavior.

Enhancements:

• Fix indentation and nesting in the SKU customisation installation block for clearer and more consistent Ansible task structure.

Tests:

• Disable moneo installation in existing test playbooks by setting hpc_install_moneo to false.

[sourcery-ai]

Reviewer's Guide

Adjusts SKU customisation task block indentation and test playbook defaults so that moneo is not installed during CI tests, and fixes a minor comment typo.

Flow diagram for SKU customisation task block indentation and execution

flowchart TD
  A[hpc_sku_customisation is true?] -->|no| Z[Skip SKU customisation block]
  A -->|yes| B[stat __hpc_azure_resource_dir/topology]
  B --> C{topology exists?}
  C -->|yes| Z
  C -->|no| D[copy topology definitions to __hpc_azure_resource_dir/topology]
  D --> E[copy graph files to __hpc_azure_resource_dir/customisations]
  E --> F[template setup_sku_customisations.sh to __hpc_azure_resource_dir/bin]
  F --> G[template remove_sku_customisations.sh to __hpc_azure_resource_dir/bin]
  G --> H[template sku_customisation.service to /etc/systemd/system]
  H --> I[enable sku_customisation.service]
  I --> J[template test-sku-setup.sh to __hpc_azure_tests_dir]

Loading

File-Level Changes

Change	Details	Files
Fix indentation and structure of SKU customisation installation block in main role tasks.	Re-indent the 'Install SKU Customisation scripts and services' block so its internal tasks are properly nested under the block directive. Ensure the conditional installation logic for topology files, graph files, setup/removal scripts, systemd service, and test script remains within the guarded block executed only when not already installed.	tasks/main.yml
Disable moneo installation in CI-oriented test playbooks and fix a typo in a test comment.	Set hpc_install_moneo: false in the default, include-vars, and skip-toolkit test playbooks to avoid installing moneo during tests. Correct the spelling in a comment from 'stest' to 'test' in the default tests playbook.	tests/tests_default.yml tests/tests_include_vars_from_parent.yml tests/tests_skip_toolkit.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}