ci: rollout several recent changes to CI testing

[richm]

• Pass in a YAML true value as __bootc_validation: true using
  the --extra-vars option to ensure that __bootc_validation is
  treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

• Use tox-lsr version 3.11.1

• Ensure the citest bad comment works when the test was cancelled in
  addition to the failure case.

• Update contributing.md documentation

• Update number of nodes to use in testing farm, if needed

• remove unnecessary ansible-lint skips

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Roll out recent CI testing improvements including YAML boolean extra-vars for validation, tox-lsr upgrade, cancelled-run handling in workflows, testing farm node adjustments, ansible-lint cleanup, and updated contributing docs

Bug Fixes:

• Handle cancelled test runs in the citest bad comment workflow

Enhancements:

• Upgrade tox-lsr to version 3.11.1

CI:

• Pass __bootc_validation as a YAML boolean via --extra-vars
• Adjust number of nodes used in the testing farm configuration

Documentation:

• Update contributing.md documentation

Chores:

• Remove unnecessary ansible-lint skips

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR streamlines CI testing by properly passing boolean flags, enhancing workflow failure detection, updating tool versions, and refining documentation and lint configurations.

Sequence diagram for improved workflow failure and cancellation detection in CI

sequenceDiagram
    participant GitHub Actions
    participant "gh CLI"
    participant "jq"
    participant User
    User->>GitHub Actions: Trigger citest bad workflow
    GitHub Actions->>"gh CLI": Query workflow runs for tft.yml
    "gh CLI"->>"jq": Filter runs by display_title and conclusion
    "jq"->>GitHub Actions: Return run ID if conclusion is "failure" or "cancelled"
    GitHub Actions->>User: Notify if failed/cancelled workflow found or exit if not

Loading

Class diagram for passing boolean extra-vars to Ansible in CI

classDiagram
    class CI_Workflow {
        +run_tests()
        +pass_extra_vars()
    }
    class Ansible {
        +__bootc_validation: bool
        +run_playbook()
    }
    CI_Workflow --> Ansible: passes __bootc_validation as boolean

Loading

File-Level Changes

Change	Details	Files
Pass __bootc_validation as a YAML boolean in test commands	Quote __bootc_validation assignment with YAML syntax Replace inline boolean flag with --extra-vars syntax	.github/workflows/qemu-kvm-integration-tests.yml
Enhance citest bad comment workflow to handle cancellations	Extend filter to include 'cancelled' conclusion Add comment noting TF tests may be cancelled	.github/workflows/tft_citest_bad.yml
Bump tox-lsr to version 3.11.1	Upgrade tox-lsr dependency to 3.11.1	tox.ini
Refresh documentation and clean up CI config	Update contributing.md Remove unnecessary ansible-lint skips Adjust testing farm node count if needed	CONTRIBUTING.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}