ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]

[richm]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 test scenarios, while optimizing container test execution behavior.

CI:

• Bump tox-lsr version from 3.16.0 to 3.17.0 across GitHub Actions workflows.
• Switch Fedora 43 qemu and container test matrices to use Ansible Core 2.20 environments.
• Adjust container test job configuration to control requirements and callback plugin setup between initial and subsequent test runs.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 test matrices, and optimizes container test runs by adjusting environment flags between first and subsequent test executions.

Sequence diagram for optimized container test runs with tox_lsr_3_17_0 and Ansible_2_20

sequenceDiagram
  actor Developer
  participant GitHubActions
  participant CIJob as CI_Job_Container_Tests
  participant ToxLsr as Tox_Lsr_3_17_0
  participant TestEnv as Container_Test_Environment
  participant Ansible220 as Ansible_2_20

  Developer ->> GitHubActions: Push changes / open PR
  GitHubActions ->> CIJob: Start container test workflow
  CIJob ->> CIJob: Install tox-lsr 3.17.0 via pip
  CIJob ->> ToxLsr: Invoke tox with container env list

  ToxLsr ->> TestEnv: First container test run with full flags
  TestEnv ->> Ansible220: Execute playbooks on Fedora 43
  Ansible220 -->> TestEnv: Test results

  ToxLsr ->> TestEnv: Subsequent container runs with optimized flags
  TestEnv ->> Ansible220: Reuse Ansible 2.20 on Fedora 43
  Ansible220 -->> TestEnv: Test results

  TestEnv -->> ToxLsr: Aggregated container test outcomes
  ToxLsr -->> CIJob: Summarized results with improved output
  CIJob -->> GitHubActions: Job status and logs
  GitHubActions -->> Developer: CI status for PR

Loading

File-Level Changes

Change	Details	Files
Update Fedora 43 qemu and container test matrices to use Ansible Core 2.20 instead of 2.19.	Change qemu Fedora 43 matrix entry to reference qemu-ansible-core-2-20 environment. Change container Fedora 43 matrix entry to reference container-ansible-core-2-20 environment. Change container Fedora 43 bootc matrix entry to reference container-ansible-core-2-20 environment.	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr dependency from 3.16.0 to 3.17.0 across CI workflows.	Update tox-lsr version in qemu-kvm integration workflow install step. Update tox-lsr version in ansible-lint workflow install step. Update tox-lsr version in ansible-managed-var-comment workflow install step. Update tox-lsr version in ansible-test workflow install step.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Adjust container test loop to leverage tox-lsr 3.17.0 optimizations by toggling requirement and callback plugin skipping after the first test run.	Remove LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY environment overrides from the container test step. Initialize SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to false before the test loop to ensure the first test run performs full setup with callbacks. Set SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to true after each iteration so subsequent tests can skip requirements installation and callback plugins for faster execution.	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The tox-lsr version string is duplicated across multiple workflows; consider centralizing it via a reusable workflow, composite action, or a single env variable to make future version bumps less error-prone.
• The new SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS logic in the container loop is subtle; it may be worth adding a brief comment explaining why only the first test run needs full setup so future changes don’t inadvertently reorder or parallelize the tests.
• Now that the LSR_CONTAINER_PROFILE/LSR_CONTAINER_PRETTY hack is removed, double-check whether any other workflows or scripts still rely on these vars to avoid inconsistent behavior between CI paths.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The tox-lsr version string is duplicated across multiple workflows; consider centralizing it via a reusable workflow, composite action, or a single env variable to make future version bumps less error-prone.
- The new SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS logic in the container loop is subtle; it may be worth adding a brief comment explaining why only the first test run needs full setup so future changes don’t inadvertently reorder or parallelize the tests.
- Now that the LSR_CONTAINER_PROFILE/LSR_CONTAINER_PRETTY hack is removed, double-check whether any other workflows or scripts still rely on these vars to avoid inconsistent behavior between CI paths.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}