Skip to content

fix: facts being gathered unnecessarily #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richm merged 1 commit into from
Jul 14, 2023
Merged

fix: facts being gathered unnecessarily #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tasks/set_vars.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
---
- name: Ensure ansible_facts used by role
setup:
gather_subset: min
when: not ansible_facts.keys() | list |
intersect(__kernel_settings_required_facts) ==
__kernel_settings_required_facts
gather_subset: "{{ __kernel_settings_required_facts_subsets }}"
when: __kernel_settings_required_facts |
difference(ansible_facts.keys() | list) | length > 0

- name: Set platform/version specific variables
include_vars: "{{ lookup('first_found', ffparams) }}"
Expand Down
6 changes: 6 additions & 0 deletions vars/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,9 @@ __kernel_settings_required_facts:
- distribution_major_version
- distribution_version
- os_family

# the subsets of ansible_facts that need to be gathered in case any of the
# facts in required_facts is missing; see the documentation of
# the 'gather_subset' parameter of the 'setup' module
__kernel_settings_required_facts_subsets: "{{ ['!all', '!min'] +
__kernel_settings_required_facts }}"