[citest skip] make min_ansible_version a string in meta/main.yml#83
Merged
richm merged 1 commit intolinux-system-roles:masterfrom Jun 28, 2022
Merged
Conversation
The Ansible developers say that `min_ansible_version` in meta/main.yml must be a `string` value like `"2.9"`, not a `float` value like `2.9`. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/linux-system-roles-kernel_settings
that referenced
this pull request
Jul 10, 2022
[1.1.9] - 2022-07-09 -------------------- REMOVE_ME: Recommend to itemize the change log entries in one of the following sections. REMOVE_ME: Use Other Changes for CI, testing, and other non-feature/non-bug related items. ### New Features ### Bug Fixes ### Other Changes - make all tests work with gather_facts: false (linux-system-roles#82) Ensure tests work when using ANSIBLE_GATHERING=explicit - [citest skip] make min_ansible_version a string in meta/main.yml (linux-system-roles#83) The Ansible developers say that `min_ansible_version` in meta/main.yml must be a `string` value like `"2.9"`, not a `float` value like `2.9`. Signed-off-by: Rich Megginson <rmeggins@redhat.com> - Add CHANGELOG.md (linux-system-roles#84) - [citest skip] Modify CHANGELOG.md (linux-system-roles#85) - Replace the ATX style with the setext style for the header H1 and H2. - Each changelog has 3 sections, "### New Features", "### Bug Fixes", and "Other Changes". - If there is no items in a section, let it have "- none". Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/linux-system-roles-kernel_settings
that referenced
this pull request
Jul 10, 2022
[1.1.9] - 2022-07-09 -------------------- ### New Features - none ### Bug Fixes - none ### Other Changes - make all tests work with gather_facts: false (linux-system-roles#82) Ensure tests work when using ANSIBLE_GATHERING=explicit - [citest skip] make min_ansible_version a string in meta/main.yml (linux-system-roles#83) The Ansible developers say that `min_ansible_version` in meta/main.yml must be a `string` value like `"2.9"`, not a `float` value like `2.9`. - Add CHANGELOG.md (linux-system-roles#84) Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/linux-system-roles-kernel_settings
that referenced
this pull request
Jul 10, 2022
[1.1.9] - 2022-07-10 -------------------- ### New Features - none ### Bug Fixes - none ### Other Changes - make all tests work with gather_facts: false (linux-system-roles#82) Ensure tests work when using ANSIBLE_GATHERING=explicit - make min_ansible_version a string in meta/main.yml (linux-system-roles#83) The Ansible developers say that `min_ansible_version` in meta/main.yml must be a `string` value like `"2.9"`, not a `float` value like `2.9`. - Add CHANGELOG.md (linux-system-roles#84) Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
that referenced
this pull request
Jul 10, 2022
[1.1.9] - 2022-07-10 -------------------- ### New Features - none ### Bug Fixes - none ### Other Changes - make all tests work with gather_facts: false (#82) Ensure tests work when using ANSIBLE_GATHERING=explicit - make min_ansible_version a string in meta/main.yml (#83) The Ansible developers say that `min_ansible_version` in meta/main.yml must be a `string` value like `"2.9"`, not a `float` value like `2.9`. - Add CHANGELOG.md (#84) Signed-off-by: Rich Megginson <rmeggins@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ansible developers say that
min_ansible_versionin meta/main.ymlmust be a
stringvalue like"2.9", not afloatvalue like2.9.Signed-off-by: Rich Megginson rmeggins@redhat.com