Conversation
bump gha checkout from v5 to v6 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates all GitHub Actions workflows to use actions/checkout v6 instead of v5 for code checkout steps across the CI pipeline. Sequence diagram for CI workflow using actions_checkout_v6sequenceDiagram
actor Developer
participant GitHub
participant Workflow_build_docs
participant actions_checkout_v6
Developer->>GitHub: Push commit / open PR
GitHub->>Workflow_build_docs: Trigger build_docs workflow
Workflow_build_docs->>actions_checkout_v6: uses actions/checkout@v6
actions_checkout_v6-->>Workflow_build_docs: Repository files checked out
Workflow_build_docs->>Workflow_build_docs: Run subsequent jobs (docs build, checks, etc.)
Workflow_build_docs-->>GitHub: Report workflow status
GitHub-->>Developer: Show CI result on commit/PR
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Since many workflows use
actions/checkout, consider extracting the common checkout step into a reusable workflow or composite action so future version bumps only need to be made in one place.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since many workflows use `actions/checkout`, consider extracting the common checkout step into a reusable workflow or composite action so future version bumps only need to be made in one place.
## Individual Comments
### Comment 1
<location> `.github/workflows/weekly_ci.yml:33` </location>
<code_context>
- name: Checkout repo
- uses: actions/checkout@v5
+ uses: actions/checkout@v6
- name: Install tox, tox-lsr
</code_context>
<issue_to_address>
**suggestion (performance):** Re-evaluate whether the explicit `apt install git` is still required now that you’re on `checkout@v6` and `ubuntu-latest`.
If you’re not depending on a special Git version or feature, the extra `apt install git` steps in these workflows are probably unnecessary, since `ubuntu-latest` already includes Git and `checkout@v6` only needs a standard install. Dropping them across the jobs would reduce runtime and avoid potential apt/network flakiness.
Suggested implementation:
```
- name: Checkout latest code
uses: actions/checkout@v6
with:
fetch-depth: 0
- name: Create or rebase commit, add dump_packages callback
```
If this workflow file contains other jobs/steps that also run `apt install git` (for example, in matrix jobs or other CI phases), you should remove those redundant installations in the same way, keeping only the checkout steps. Ensure any remaining `apt` usage (e.g., for other packages) doesn’t implicitly reintroduce `git` dependence assumptions.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| - name: Checkout latest code | ||
| uses: actions/checkout@v5 | ||
| uses: actions/checkout@v6 |
There was a problem hiding this comment.
suggestion (performance): Re-evaluate whether the explicit apt install git is still required now that you’re on checkout@v6 and ubuntu-latest.
If you’re not depending on a special Git version or feature, the extra apt install git steps in these workflows are probably unnecessary, since ubuntu-latest already includes Git and checkout@v6 only needs a standard install. Dropping them across the jobs would reduce runtime and avoid potential apt/network flakiness.
Suggested implementation:
- name: Checkout latest code
uses: actions/checkout@v6
with:
fetch-depth: 0
- name: Create or rebase commit, add dump_packages callback
If this workflow file contains other jobs/steps that also run apt install git (for example, in matrix jobs or other CI phases), you should remove those redundant installations in the same way, keeping only the checkout steps. Ensure any remaining apt usage (e.g., for other packages) doesn’t implicitly reintroduce git dependence assumptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump gha checkout from v5 to v6
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
CI: