ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]

[richm]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 test scenarios, while optimizing container test execution behavior.

CI:

• Switch Fedora 43 qemu and container integration test scenarios to use Ansible Core 2.20.
• Upgrade tox-lsr version from 3.16.0 to 3.17.0 across GitHub Actions workflows.
• Adjust container integration test job environment flags to avoid skipping requirements and callback plugins on the first run, then enable skipping for subsequent tests.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 qemu/container tests, and optimizes container test runs by adjusting environment flags between the first and subsequent test executions.

Sequence diagram for updated container test execution with tox_lsr_3_17_0

sequenceDiagram
    actor Developer
    participant GitHubActions
    participant AnsibleTestWorkflow
    participant ToxLsr_3_17_0
    participant ContainerTestRunner
    participant Ansible_2_20
    participant Fedora43Container

    Developer->>GitHubActions: push_or_pr_event
    GitHubActions->>AnsibleTestWorkflow: start_job

    AnsibleTestWorkflow->>AnsibleTestWorkflow: install_tox_lsr_3_17_0
    AnsibleTestWorkflow->>ToxLsr_3_17_0: invoke_tox_environment

    alt first_test_run
        ToxLsr_3_17_0->>ContainerTestRunner: run_tests_with_full_env
        ContainerTestRunner->>Ansible_2_20: execute_playbooks
        Ansible_2_20->>Fedora43Container: run_qemu_container_tests
        Fedora43Container-->>Ansible_2_20: test_results
        Ansible_2_20-->>ContainerTestRunner: results
        ContainerTestRunner-->>ToxLsr_3_17_0: results
    else subsequent_test_runs
        ToxLsr_3_17_0->>ContainerTestRunner: run_tests_with_optimized_flags
        ContainerTestRunner->>Ansible_2_20: execute_playbooks
        Ansible_2_20->>Fedora43Container: run_qemu_container_tests
        Fedora43Container-->>Ansible_2_20: test_results
        Ansible_2_20-->>ContainerTestRunner: results
        ContainerTestRunner-->>ToxLsr_3_17_0: results
    end

    ToxLsr_3_17_0-->>AnsibleTestWorkflow: summarized_output
    AnsibleTestWorkflow-->>GitHubActions: job_status
    GitHubActions-->>Developer: ci_status

Loading

File-Level Changes

Change	Details	Files
Bump tox-lsr dependency in all relevant GitHub Actions workflows to 3.17.0.	Update pip install command in qemu-kvm integration workflow to reference tox-lsr 3.17.0 instead of 3.16.0. Update pip install command in ansible-lint workflow to reference tox-lsr 3.17.0 instead of 3.16.0. Update pip install command in ansible-managed-var-comment workflow to reference tox-lsr 3.17.0 instead of 3.16.0. Update pip install command in ansible-test workflow to reference tox-lsr 3.17.0 instead of 3.16.0.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Switch Fedora 43 qemu and container test matrix entries to use Ansible 2.20.	Change qemu Fedora 43 matrix env from qemu-ansible-core-2-19 to qemu-ansible-core-2-20. Change container Fedora 43 matrix env from container-ansible-core-2-19 to container-ansible-core-2-20. Change container Fedora 43 bootc matrix env from container-ansible-core-2-19 to container-ansible-core-2-20.	.github/workflows/qemu-kvm-integration-tests.yml
Adjust container test loop environment flags to leverage tox-lsr 3.17.0 features for faster subsequent runs.	Remove LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY overrides before running container tests. Introduce SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS flags, initially set to false for the first test run. Set SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to true after each test iteration so that subsequent test runs can skip those steps.	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider defining the tox-lsr version (3.17.0) in one place (e.g., a reusable workflow, env var, or composite action) to avoid having to update it in multiple workflow files in the future.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider defining the tox-lsr version (3.17.0) in one place (e.g., a reusable workflow, env var, or composite action) to avoid having to update it in multiple workflow files in the future.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}