Skip to content

refactor: support ansible 2.19#80

Merged
richm merged 1 commit intolinux-system-roles:mainfrom
richm:fix-ansible-2.19
Jul 1, 2025
Merged

refactor: support ansible 2.19#80
richm merged 1 commit intolinux-system-roles:mainfrom
richm:fix-ansible-2.19

Conversation

@richm
Copy link
Copy Markdown
Contributor

@richm richm commented Jul 1, 2025

Do not use ansible_managed directly

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Refactor tests to avoid direct use of ansible_managed by renaming it to __ansible_managed for compatibility with Ansible 2.19

Enhancements:

  • Support Ansible 2.19 by replacing direct ansible_managed references with __ansible_managed

Tests:

  • Update check_header.yml assertions to verify __ansible_managed instead of ansible_managed

Do not use ansible_managed directly

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner July 1, 2025 16:01
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jul 1, 2025

Reviewer's Guide

Refactor test to replace direct use of ansible_managed with __ansible_managed for compatibility with Ansible 2.19 by updating the assertion and variable lookup in the header check task.

File-Level Changes

Change Details Files
Rename ansible_managed reference to __ansible_managed
  • Update assertion to check __ansible_managed in content
  • Modify variable lookup from ansible_managed to __ansible_managed
tests/tasks/check_header.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @richm - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit d89fe9a into linux-system-roles:main Jul 1, 2025
19 of 22 checks passed
@richm richm deleted the fix-ansible-2.19 branch July 1, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant