Skip to content

fix: Add SLES_16 var file with required packages and ensure pyasn1#84

Merged
richm merged 2 commits intolinux-system-roles:mainfrom
HVSharma12:sles16-vars-pyasn1
Jul 30, 2025
Merged

fix: Add SLES_16 var file with required packages and ensure pyasn1#84
richm merged 2 commits intolinux-system-roles:mainfrom
HVSharma12:sles16-vars-pyasn1

Conversation

@HVSharma12
Copy link
Copy Markdown
Contributor

@HVSharma12 HVSharma12 commented Jul 30, 2025

Enhancement: Add sles_16 vars file ensuring required Python dependencies are present.

Reason: Keylime components on SLES 16 require pyasn1 and pyasn1-modules

Result: Prevents missing dependency errors related to pyasn1 while starting keylime services

Issue Tracker Tickets (Jira or BZ if any): na

Summary by Sourcery

Add support for SLES 16 by providing var files with required Keylime components and Python dependencies to ensure pyasn1 is available and avoid runtime errors.

New Features:

  • Add SLES_16 and SLES_SAP_16 vars files listing Keylime server packages for SLES 16

Bug Fixes:

  • Include python313-pyasn1 and python313-pyasn1-modules to prevent missing dependency errors on SLES 16

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jul 30, 2025

Reviewer's Guide

Adds new SLES 16 variable files listing Keylime server packages and required Python dependencies (pyasn1 and pyasn1-modules) to prevent missing dependency errors when starting Keylime services on SLES 16.

File-Level Changes

Change Details Files
Introduce SLES_16 vars file with required Keylime and pyasn1 packages
  • Create vars/SLES_16.yml
  • Include keylime-verifier and keylime-registrar in package list
  • Add python313-pyasn1 and python313-pyasn1-modules dependencies
vars/SLES_16.yml
Introduce SLES_SAP_16 vars file mirroring SLES_16 package requirements
  • Create vars/SLES_SAP_16.yml
  • Mirror Keylime server packages list
  • Include python313-pyasn1 and python313-pyasn1-modules dependencies
vars/SLES_SAP_16.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @HVSharma12 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm
Copy link
Copy Markdown
Contributor

richm commented Jul 30, 2025

@HVSharma12 if these are identical, you could make one a symlink to the other

@richm richm merged commit b53ea83 into linux-system-roles:main Jul 30, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants