Skip to content

ci: bump tox-lsr to 3.14.0 - this moves standard-inventory-qcow2 to tox-lsr#98

Merged
richm merged 1 commit intomainfrom
tox-lsr-3.14.0
Nov 11, 2025
Merged

ci: bump tox-lsr to 3.14.0 - this moves standard-inventory-qcow2 to tox-lsr#98
richm merged 1 commit intomainfrom
tox-lsr-3.14.0

Conversation

@richm
Copy link
Copy Markdown
Contributor

@richm richm commented Nov 11, 2025

Previously, CI would download the standard-inventory-qcow2 script from pagure. However,
the pagure download url is now being protected by Anubis which by default
will check the User-Agent header and deny attempts from clients that look
like scrapers or hackers. Rather than trying to play arms race with setting
headers, etc. - just move this script to tox-lsr. If we really need to sync
with the upstream development, we can do that manually.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

CI:

  • Bump tox-lsr from 3.13.0 to 3.14.0 in ansible-lint, ansible-managed-var-comment, ansible-test, and qemu-kvm-integration-tests workflows

…ox-lsr

Previously, CI would download the standard-inventory-qcow2 script from pagure.  However,
the pagure download url is now being protected by Anubis which by default
will check the User-Agent header and deny attempts from clients that look
like scrapers or hackers. Rather than trying to play arms race with setting
headers, etc. - just move this script to tox-lsr. If we really need to sync
with the upstream development, we can do that manually.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner November 11, 2025 13:50
@richm richm self-assigned this Nov 11, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Nov 11, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates all CI workflows to use the latest tox-lsr 3.14.0 release—bringing in the standard-inventory-qcow2 script locally and avoiding protected URL downloads.

File-Level Changes

Change Details Files
Bump tox-lsr version from 3.13.0 to 3.14.0 across CI workflows to include standard-inventory-qcow2
  • Updated pip install command in ansible-lint workflow
  • Updated pip install command in ansible-managed-var-comment workflow
  • Updated pip install command in ansible-test workflow
  • Updated pip install command in qemu-kvm-integration-tests workflow
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Extract the tox-lsr version into a shared input or environment variable (or even a composite action) so future bumps only require changing it in one place.
  • Verify that all direct references or tests for the standard-inventory-qcow2 script have been updated to use tox-lsr@3.14.0 and remove any leftover download logic.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Extract the tox-lsr version into a shared input or environment variable (or even a composite action) so future bumps only require changing it in one place.
- Verify that all direct references or tests for the standard-inventory-qcow2 script have been updated to use tox-lsr@3.14.0 and remove any leftover download logic.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit cbda07f into main Nov 11, 2025
22 of 24 checks passed
@richm richm deleted the tox-lsr-3.14.0 branch November 11, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant