refactor: Use meaningful variable#654
Merged
richm merged 1 commit intolinux-system-roles:mainfrom Dec 1, 2023
Merged
Conversation
liangwen12year
force-pushed
the
code_refactor
branch
from
03907bc to
6ae20b8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
=======================================
Coverage 43.31% 43.31%
=======================================
Files 13 13
Lines 3068 3068
Branches 394 394
=======================================
Hits 1329 1329
Misses 1739 1739
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
richm
changed the title
liangwen12year
force-pushed
the
code_refactor
branch
from
6ae20b8 to
7df3d2d
Compare
Contributor
Author
|
[citest] |
liangwen12year
force-pushed
the
code_refactor
branch
from
7df3d2d to
23fb22b
Compare
Contributor
Author
|
[citest] |
1 similar comment
Contributor
Author
|
[citest] |
Some variables used in the module code are not meaningful at all, which might be hard to read and understand. Therefore, replace them with meaningful variables. Signed-off-by: Wen Liang <liangwen12year@gmail.com>
liangwen12year
force-pushed
the
code_refactor
branch
from
23fb22b to
7e7dacf
Compare
Contributor
Author
|
[citest] |
richm
approved these changes
Dec 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement:
refractor: Use meaningful variable
Reason:
Some variables used in the module code are not meaningful at all, which mgiht be hard to read and understand. Therefore, replace them with meaningful variables.
Result:
Issue Tracker Tickets (Jira or BZ if any):