ci: Comply with Ansible partner certification checking [citest_skip]#234
Merged
ci: Comply with Ansible partner certification checking [citest_skip]#234
Conversation
https://github.com/ansible-collections/partner-certification-checker/blob/main/README.md Unfortunately we cannot use the checkers provided by their team because they assume the git repo is in collection format - you cannot convert to collection format first then point the checkers at that collection. Instead, implement our own checkers that do the same (and more) - check with multiple versions of ansible-lint and ansible-test to ensure we cover: * all supported versions of EL * Automation Hub gating * the latest versions of Ansible, including the latest milestone version This requires the latest version of tox-lsr Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideCI workflows are updated to use tox-lsr 3.18.0 and to run ansible-lint and ansible-test via tox matrices covering multiple Ansible and Python versions in alignment with Ansible partner certification requirements, replacing direct GitHub Actions integrations and manual collection-handling logic. Flow diagram for ansible-lint CI job with tox matrixflowchart TD
S[Start ansible_lint_job] --> C[Checkout code]
C --> U[Update pip and git]
U --> I[pip install tox and tox_lsr_3_18_0]
I --> M{Matrix version}
M -->|version_set_1\nansible_lint_24.x\nansible_core_2.16.x\npython_3.12| P1[actions_setup_python python_3_12]
M -->|version_set_2\nansible_lint_26.x\nansible_core_2.20.x\npython_3.13| P2[actions_setup_python python_3_13]
P1 --> E1[set LSR_ANSIBLE_LINT_DEP and LSR_ANSIBLE_LINT_ANSIBLE_DEP]
P2 --> E2[set LSR_ANSIBLE_LINT_DEP and LSR_ANSIBLE_LINT_ANSIBLE_DEP]
E1 --> T1[tox -e collection,ansible-lint-collection\nbasepython python3_12]
E2 --> T2[tox -e collection,ansible-lint-collection\nbasepython python3_13]
T1 --> R1[Run ansible-lint inside collection env]
T2 --> R2[Run ansible-lint inside collection env]
R1 --> F[Job complete]
R2 --> F
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/ansible-collections/partner-certification-checker/blob/main/README.md
Unfortunately we cannot use the checkers provided by their team because they assume
the git repo is in collection format - you cannot convert to collection format first
then point the checkers at that collection. Instead, implement our own checkers that
do the same (and more) - check with multiple versions of ansible-lint and ansible-test
to ensure we cover:
This requires the latest version of tox-lsr
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI workflows to run Ansible lint and test checks across multiple supported Ansible and Python versions to align with partner certification requirements.
CI: