Skip to content

ci: ansible-lint requires dependencies to be installed [citest_skip]#235

Merged
richm merged 1 commit intomainfrom
ci-ansible-lint-install-deps
Apr 9, 2026
Merged

ci: ansible-lint requires dependencies to be installed [citest_skip]#235
richm merged 1 commit intomainfrom
ci-ansible-lint-install-deps

Conversation

@richm
Copy link
Copy Markdown
Contributor

@richm richm commented Apr 9, 2026

ansible-lint requires the dependencies in meta/collection-requirements.yml
and tests/collection-requirements.yml to be installed. tox-lsr 3.18.1
will ensure they are installed.

Refactor the tests somewhat so that the collection and test steps are separate.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use the latest tox-lsr release and separate collection conversion from linting and testing steps.

CI:

  • Bump tox-lsr used in GitHub Actions workflows from 3.18.0 to 3.18.1.
  • Split ansible-lint and ansible-test workflows into distinct collection conversion and execution steps while adjusting tox environments accordingly.

ansible-lint requires the dependencies in meta/collection-requirements.yml
and tests/collection-requirements.yml to be installed.  tox-lsr 3.18.1
will ensure they are installed.

Refactor the tests somewhat so that the collection and test steps are separate.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from Jakuje as a code owner April 9, 2026 23:01
@richm richm self-assigned this Apr 9, 2026
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 9, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GitHub Actions CI workflows to use tox-lsr 3.18.1 and refactors ansible-lint and ansible-test jobs to run collection conversion and lint/test steps separately, while keeping other workflows aligned on the new tox-lsr version.

File-Level Changes

Change Details Files
Upgrade tox-lsr version used across CI workflows to 3.18.1.
  • Bump tox-lsr installation from 3.18.0 to 3.18.1 in ansible-lint workflow.
  • Bump tox-lsr installation from 3.18.0 to 3.18.1 in ansible-test workflow.
  • Bump tox-lsr installation from 3.18.0 to 3.18.1 in ansible-managed-var-comment workflow.
  • Bump tox-lsr installation from 3.18.0 to 3.18.1 in qemu-kvm-integration-tests workflow.
.github/workflows/ansible-lint.yml
.github/workflows/ansible-test.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/qemu-kvm-integration-tests.yml
Refactor ansible-lint workflow to separate collection conversion from ansible-lint execution.
  • Introduce a dedicated 'Convert role to collection format' step that runs 'tox -e collection'.
  • Adjust ansible-lint step to only run 'tox -e ansible-lint-collection' instead of combining collection and ansible-lint in a single tox invocation.
  • Keep ansible/ansible-lint/ansible-core versions parameterized via matrix and environment variables while simplifying the tox environment list.
.github/workflows/ansible-lint.yml
Refactor ansible-test workflow to separate collection conversion from ansible-test execution and simplify tox environment usage.
  • Introduce a dedicated 'Convert role to collection format' step that runs 'tox -e collection'.
  • Adjust ansible-test step to run only the ansible-test environment instead of combining collection and ansible-test in one tox call.
  • Preserve dynamic basepython selection via tox's 'testenv:ansible-test-.basepython' override while narrowing the environment list to the ansible-test env.
.github/workflows/ansible-test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 6498983 into main Apr 9, 2026
30 checks passed
@richm richm deleted the ci-ansible-lint-install-deps branch April 9, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant