Replace selectattr filter with json_query filter#56
Merged
pcahyna merged 2 commits intolinux-system-roles:masterfrom Jan 14, 2020
Merged
Replace selectattr filter with json_query filter#56pcahyna merged 2 commits intolinux-system-roles:masterfrom
pcahyna merged 2 commits intolinux-system-roles:masterfrom
Conversation
Member
|
fixes #49 (hopefully) |
pcahyna
reviewed
Oct 22, 2019
Contributor
Author
|
[citest bad] |
Some tests (like comparison) are missing in older Jinja. That makes selectattr filter unusable on RHEL 7. Signed-off-by: Vaclav Dolezal <vdolezal@redhat.com>
Member
|
@dwlehman if there are no objections, I would like to merge it, because otherwise we have a problem with the soreage role on RHEL 7. |
dwlehman
approved these changes
Jan 7, 2020
Collaborator
dwlehman
left a comment
dwlehman
left a comment
There was a problem hiding this comment.
Looks good to me, although I have no experience with json_query.
pcahyna
reviewed
Jan 13, 2020
pcahyna
reviewed
Jan 13, 2020
Signed-off-by: Vaclav Dolezal <vdolezal@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests (like comparison) are missing in older Jinja. That makes
selectattr filter unusable on RHEL 7.