ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]

[richm]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 test environments, improving container test performance and output.

CI:

• Bump tox-lsr version from 3.16.0 to 3.17.0 across GitHub Actions workflows for linting, ansible tests, and Python unit tests.
• Adjust Fedora 43 qemu and container test matrices to run against Ansible Core 2.20 instead of 2.19.
• Optimize container test job loop by only running requirements and callback plugin setup on the first test iteration to speed up subsequent runs.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 test scenarios, and adjusts container test environment flags to leverage new tox-lsr behavior for faster, clearer container runs.

Sequence diagram for CI job execution with tox_lsr_3_17_0 and Ansible_2_20 on Fedora_43

sequenceDiagram
  actor Developer
  participant GitHub as GitHub
  participant Workflow as GitHub_Actions_Workflow
  participant Runner as GHA_Runner
  participant Pip as pip3
  participant Tox as tox
  participant ToxLsr as tox_lsr_3_17_0
  participant Fedora43 as Fedora_43_Test_Env
  participant Ansible as Ansible_2_20
  participant Tests as Test_Suite

  Developer->>GitHub: Push commits or open PR
  GitHub-->>Workflow: Trigger CI workflows
  Workflow-->>Runner: Start ansible_test and related jobs

  Runner->>Pip: pip3 install tox and tox_lsr_3_17_0
  Pip-->>Runner: tox and tox_lsr_3_17_0 installed

  Runner->>Tox: Invoke tox for CI environment
  Tox->>ToxLsr: Use tox_lsr_3_17_0 configuration

  ToxLsr->>Fedora43: Start Fedora 43 container or qemu guest
  Fedora43->>Ansible: Provision environment with Ansible_2_20

  ToxLsr->>Tests: Run Ansible and integration tests
  Tests->>Ansible: Execute playbooks and roles
  Ansible-->>Tests: Test results

  Tests-->>ToxLsr: Aggregate results
  ToxLsr-->>Tox: Return job status
  Tox-->>Runner: Report success or failure
  Runner-->>Workflow: Complete job with status
  Workflow-->>GitHub: Update PR checks
  GitHub-->>Developer: Display CI status on PR

Loading

File-Level Changes

Change	Details	Files
Bump Ansible core version to 2.20 for Fedora 43 qemu and container test scenarios.	Update Fedora 43 qemu matrix entry to use qemu-ansible-core-2-20 environment. Update Fedora 43 container matrix entry to use container-ansible-core-2-20 environment. Update Fedora 43 bootc container matrix entry to use container-ansible-core-2-20 environment.	.github/workflows/qemu-kvm-integration-tests.yml
Upgrade tox-lsr dependency from 3.16.0 to 3.17.0 across CI workflows.	Change pip install command in qemu-kvm-integration-tests workflow to use tox-lsr@3.17.0. Change pip install command in ansible-lint workflow to use tox-lsr@3.17.0. Change pip install command in ansible-managed-var-comment workflow to use tox-lsr@3.17.0. Change pip install command in ansible-test workflow to use tox-lsr@3.17.0. Change pip install command in python-unit-test workflow to use tox-lsr@3.17.0.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Adjust container test loop environment flags to align with new tox-lsr behavior and optimize subsequent test runs.	Remove legacy LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY overrides in container test step. Initialize SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to false before the first container test run. Set SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to true after each test iteration so subsequent runs can skip requirements and callback plugin setup.	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider defining the tox-lsr version and Ansible core versions in a single shared place (e.g., workflow env or reusable workflow) to avoid updating multiple hard-coded strings when versions change.
• In the container test loop, it might be clearer to explicitly reset SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS before the loop and then only set them once inside, to avoid relying on the comment to explain the first-vs-subsequent run behavior.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider defining the tox-lsr version and Ansible core versions in a single shared place (e.g., workflow env or reusable workflow) to avoid updating multiple hard-coded strings when versions change.
- In the container test loop, it might be clearer to explicitly reset SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS before the loop and then only set them once inside, to avoid relying on the comment to explain the first-vs-subsequent run behavior.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}