ci: Comply with Ansible partner certification checking [citest_skip]

[richm]

https://github.com/ansible-collections/partner-certification-checker/blob/main/README.md

Unfortunately we cannot use the checkers provided by their team because they assume
the git repo is in collection format - you cannot convert to collection format first
then point the checkers at that collection. Instead, implement our own checkers that
do the same (and more) - check with multiple versions of ansible-lint and ansible-test
to ensure we cover:

• all supported versions of EL
• Automation Hub gating
• the latest versions of Ansible, including the latest milestone version

This requires the latest version of tox-lsr

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to align ansible-lint and ansible-test checks with Ansible partner certification requirements by testing against multiple supported Ansible and Python versions.

CI:

• Run ansible-lint in CI via tox with a version matrix covering Automation Hub gating and latest Ansible/ansible-lint combinations instead of the ansible-lint GitHub Action.
• Run ansible-test in CI via tox across a matrix of supported and milestone Ansible core and Python versions instead of the ansible-test GitHub Action.
• Upgrade tox-lsr to version 3.18.0 across ansible-lint, ansible-test, ansible-managed-var-comment, python-unit-test, and qemu-kvm-integration-tests workflows.

[sourcery-ai]

Reviewer's Guide

Update CI workflows to align with Ansible partner certification requirements by running ansible-lint and ansible-test via tox across multiple Ansible/Python versions, and bump tox-lsr to 3.18.0 across all workflows.

File-Level Changes

Change	Details	Files
Run ansible-lint via tox across a matrix of ansible-lint/ansible-core/Python versions instead of using the ansible-lint GitHub Action on a pre-converted collection.	Add a GitHub Actions strategy matrix for ansible-lint with two version tuples that match Automation Hub gating and latest tooling. Upgrade tox-lsr to 3.18.0 in the ansible-lint workflow. Replace the previous shell-based collection conversion plus ansible-lint GitHub Action invocation with a single tox invocation that converts to a collection and runs ansible-lint using LSR_ANSIBLE_LINT_* dependency overrides and basepython tied to the matrix Python version.	.github/workflows/ansible-lint.yml
Run ansible-test via tox across a matrix of Ansible/Python versions instead of using the ansible-test GitHub Action on a single stable version.	Add a GitHub Actions strategy matrix for ansible-test with multiple ansible-core release lines and a milestone build mapped to corresponding Python versions. Upgrade tox-lsr to 3.18.0 in the ansible-test workflow. Replace the ansible-test GitHub Action invocation with tox-driven collection conversion and ansible-test envs using testenv-specific basepython overrides tied to the matrix.	.github/workflows/ansible-test.yml
Align remaining CI workflows on tox-lsr 3.18.0 to match the new lint/test setup.	Bump tox-lsr version from 3.17.1 to 3.18.0 in the ansible-managed-var-comment workflow. Bump tox-lsr version from 3.17.1 to 3.18.0 in the python-unit-test workflow. Bump tox-lsr version from 3.17.1 to 3.18.0 in the qemu-kvm-integration-tests workflow.	.github/workflows/ansible-managed-var-comment.yml .github/workflows/python-unit-test.yml .github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The tox-lsr git URL and version (3.18.0) are duplicated across multiple workflows; consider centralizing this (e.g., via a reusable workflow, composite action, or YAML anchors) so future version bumps only need to be made in one place.
• The ansible/ansible-lint/ansible-test version matrices are currently hardcoded in the workflows; it may be worth extracting these into a single source of truth (or adding a brief comment with the upstream reference) to reduce the risk of them drifting out of sync with the partner certification checker expectations.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The tox-lsr git URL and version (3.18.0) are duplicated across multiple workflows; consider centralizing this (e.g., via a reusable workflow, composite action, or YAML anchors) so future version bumps only need to be made in one place.
- The ansible/ansible-lint/ansible-test version matrices are currently hardcoded in the workflows; it may be worth extracting these into a single source of truth (or adding a brief comment with the upstream reference) to reduce the risk of them drifting out of sync with the partner certification checker expectations.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}