ci: Comply with Ansible partner certification checking [citest_skip]

[richm]

https://github.com/ansible-collections/partner-certification-checker/blob/main/README.md

Unfortunately we cannot use the checkers provided by their team because they assume
the git repo is in collection format - you cannot convert to collection format first
then point the checkers at that collection. Instead, implement our own checkers that
do the same (and more) - check with multiple versions of ansible-lint and ansible-test
to ensure we cover:

• all supported versions of EL
• Automation Hub gating
• the latest versions of Ansible, including the latest milestone version

This requires the latest version of tox-lsr

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to run Ansible lint and test checks in matrixed environments aligned with Ansible partner certification requirements and newer tooling.

CI:

• Run ansible-lint in collection format across multiple Ansible and Python versions using tox instead of the ansible-lint GitHub Action.
• Run ansible-test sanity checks via tox across a matrix of Ansible core and Python versions, including milestone releases.
• Upgrade GitHub workflows to use tox-lsr 3.18.0 for linting, testing, and integration jobs.

[sourcery-ai]

Reviewer's Guide

Updates CI workflows to align with Ansible partner certification requirements by running ansible-lint and ansible-test via tox-lsr across multiple Ansible/Python versions, and bumps tox-lsr to 3.18.0 across workflows.

Flow diagram for updated ansible-lint GitHub Actions job

flowchart TD
  A[Job start: ansible-lint workflow] --> B{citest_skip in title or commit?}
  B -- yes --> Z[Skip job]
  B -- no --> C["Start matrix over versions\n(ansible-lint/ansible-core/Python)"]

  C --> D[Update pip and git]
  D --> E[Install tox-lsr 3.18.0 with pip]
  E --> F["Set up Python via actions/setup-python\nusing matrix.versions.python"]
  F --> G["Run tox with env vars\nLSR_ANSIBLE_LINT_DEP\nLSR_ANSIBLE_LINT_ANSIBLE_DEP\n-e collection,ansible-lint-collection\nbasepython=matrix Python"]
  G --> H["ansible-lint runs on converted collection\nacross all matrix versions"]
  H --> I[Job complete]

Loading

File-Level Changes

Change	Details	Files
Run ansible-lint via tox-lsr across a matrix of ansible-lint, ansible-core, and Python versions instead of the ansible-lint GitHub Action.	Add a strategy.matrix to the ansible-lint workflow to cover Automation Hub gating and latest ansible-lint/ansible-core/Python combinations. Upgrade tox-lsr used in the ansible-lint workflow from version 3.17.1 to 3.18.0. Replace the ansible-lint GitHub Action step with a tox invocation that converts the role to a collection and runs the ansible-lint-collection environment using LSR_ANSIBLE_LINT_DEP and LSR_ANSIBLE_LINT_ANSIBLE_DEP to pin tool versions. Introduce actions/setup-python to select the matrix Python version for the ansible-lint job. Remove the custom shell logic that post-processed the converted collection directory and merged collection requirements files, delegating that behavior to tox-lsr/testenv configuration.	.github/workflows/ansible-lint.yml
Run ansible-test via tox-lsr across a matrix of Ansible and Python versions instead of the ansible-test GitHub Action.	Add a strategy.matrix to the ansible-test workflow to run sanity tests against multiple stable and milestone Ansible core versions paired with appropriate Python versions. Upgrade tox-lsr used in the ansible-test workflow from version 3.17.1 to 3.18.0. Introduce actions/setup-python to select the matrix Python version for the ansible-test job. Replace the ansible-test GitHub Action with a tox invocation that converts the role to a collection and runs the ansible-test-* environments keyed by the matrix ansible version.	.github/workflows/ansible-test.yml
Align other CI workflows with the new tox-lsr version.	Upgrade tox-lsr from version 3.17.1 to 3.18.0 in the ansible-managed-var-comment workflow. Upgrade tox-lsr from version 3.17.1 to 3.18.0 in the qemu-kvm-integration-tests workflow.	.github/workflows/ansible-managed-var-comment.yml .github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• In the ansible-lint workflow, LSR_ANSIBLE_LINT_DEP and LSR_ANSIBLE_LINT_ANSIBLE_DEP use == with wildcard versions like 24.*, which is not a valid pip version specifier; consider switching to an exact version or a compatible range like ~=24.0 instead of including *.
• Both the ansible-lint and ansible-test workflows install tox/tox-lsr before actions/setup-python, so tox is installed into the default runner Python rather than the matrix Python; consider running setup-python first so tox and its deps are consistently tied to the selected Python version.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In the ansible-lint workflow, `LSR_ANSIBLE_LINT_DEP` and `LSR_ANSIBLE_LINT_ANSIBLE_DEP` use `==` with wildcard versions like `24.*`, which is not a valid pip version specifier; consider switching to an exact version or a compatible range like `~=24.0` instead of including `*`.
- Both the ansible-lint and ansible-test workflows install `tox`/`tox-lsr` before `actions/setup-python`, so `tox` is installed into the default runner Python rather than the matrix Python; consider running `setup-python` first so `tox` and its deps are consistently tied to the selected Python version.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}