Fix/tolerate nil target in parameter expanding#123
Merged
Conversation
Signed-off-by: Ilya <rihter007@inbox.ru>
rihter007
force-pushed
the
fix/tolerate_nil_target_in_parameter_expanding
branch
from
c975be7 to
c9d4fc5
Compare
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
==========================================
- Coverage 63.92% 63.88% -0.04%
==========================================
Files 164 164
Lines 10321 10321
==========================================
- Hits 6598 6594 -4
- Misses 3007 3011 +4
Partials 716 716
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mimir-d
approved these changes
Aug 9, 2022
| } | ||
| funcs := getFuncMap() | ||
| if vars != nil { | ||
| if target != nil && vars != nil { |
Contributor
Author
There was a problem hiding this comment.
I noticed that some plugins set target to nil when calling Expand and because step variables use it I decided to make code safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.