Conversation
rihter007
changed the base branch from
main
to
refactor/remove_step_stopping_loop
rihter007
force-pushed
the
refactor/remove_run_monitor
branch
from
6a44115 to
c5c6a63
Compare
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 63.61% 63.47% -0.14%
==========================================
Files 164 164
Lines 10330 10309 -21
==========================================
- Hits 6571 6544 -27
- Misses 3036 3043 +7
+ Partials 723 722 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rihter007
force-pushed
the
refactor/remove_run_monitor
branch
from
c5c6a63 to
ef74c93
Compare
| // It also monitors steps for critical errors and cancels the whole run. | ||
| // Note: input channels remain open when cancellation is requested, | ||
| // plugins are expected to handle it explicitly. | ||
| func (tr *TestRunner) runMonitor(ctx xcontext.Context) error { |
There was a problem hiding this comment.
iirc, this monitor was supposed to check for plugins misbehaving (or deadlocking, since theyre considered "user code"). what's handling that now?
There was a problem hiding this comment.
It is checked implicitly inside targetHandler when it tries to add/wait for a target result from a misbehaving step, it gets an error.
I can make the check more explicit to avoid possible errors
There was a problem hiding this comment.
yeah, if you could add the "detect deadlock" feature to be more explicit, that'd be nice
rihter007
force-pushed
the
refactor/remove_step_stopping_loop
branch
2 times, most recently
from
ad10ec4 to
e9a9bd1
Compare
…red in stepsTargetsCount Signed-off-by: Ilya <rihter007@inbox.ru>
…urn errors. Make TestRunner targets a local variable Signed-off-by: Ilya <rihter007@inbox.ru>
rihter007
force-pushed
the
refactor/remove_run_monitor
branch
from
ef74c93 to
2ef0ed9
Compare
Signed-off-by: Ilya <rihter007@inbox.ru>
…the first one Signed-off-by: Ilya <rihter007@inbox.ru>
3 participants
TestRunner: Remove RunMonitor. Make all targetHandlers explicitly return errors. Make TestRunner targets a local variable.
Finally got rid of conditional variable + complex state monitoring