Add http config options#132
Conversation
| flagInstanceTag *string | ||
| flagLogLevel *string | ||
| flagAdminServerAddr *string | ||
| flagHttpLoggerBufferSize *int |
There was a problem hiding this comment.
is there a way to separate these in another set or something? seems like a lot of noise for the main server flags and not much value, since defaults are almost always acceptable
There was a problem hiding this comment.
Is it possible to use more than one set?
There was a problem hiding this comment.
yes and no; it would be a bit difficult with this flags package, so id leave it as is for now
- Add options to override http logger defaults from the cli Signed-off-by: Mohamed Abokammer <mahmednabil109@gmail.com>
90c1690 to
087509f
Compare
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
==========================================
- Coverage 63.61% 63.52% -0.09%
==========================================
Files 164 164
Lines 10330 10346 +16
==========================================
+ Hits 6571 6572 +1
- Misses 3036 3052 +16
+ Partials 723 722 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Mohamed Abokammer mahmednabil109@gmail.com