Utk support for subcommands#5
Merged
GanShun merged 2 commits intolinuxboot:masterfrom Jun 8, 2018
Merged
Conversation
Signed-off-by: Gan Shun Lim <ganshun@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
====================================
Coverage 0% 0%
====================================
Files 11 11
Lines 448 467 +19
====================================
- Misses 448 467 +19
Continue to review full report at Codecov.
|
rminnich
previously approved these changes
Jun 8, 2018
| func (*parseCmd) SetFlags(_ *flag.FlagSet) {} | ||
|
|
||
| func (*parseCmd) Execute(_ context.Context, f *flag.FlagSet, _ ...interface{}) subcommands.ExitStatus { | ||
| if len(f.Args()) == 0 { |
Contributor
There was a problem hiding this comment.
This is all fine, one thought: I once had it suggested to me that if you use f.Args() more than once, you should just do args := f.Args() since the call cost is nontrivial. I don't necessarily agree with this, but thought I'd mention it.
Contributor
There was a problem hiding this comment.
chris, in case you doing me on this, it was a comment from Adin :-)
The idea is that in the future, you'll do something like utk parse or utk extract <rom> Signed-off-by: Gan Shun Lim <ganshun@gmail.com>
rminnich
approved these changes
Jun 8, 2018
Contributor
rminnich
left a comment
rminnich
left a comment
There was a problem hiding this comment.
ok that's weird I thought I just approved this one.
Member
Author
|
That's cause I just made the change you suggested and pushed again |
xaionaro
added a commit
that referenced
this pull request
May 9, 2023
Go checks the pointers used, and it is required to follow the rule #5 of "unsafe.Pointer" which requires to convert back to "unsafe.Pointer" no later than in the same line where it was converted to uintptr.
xaionaro
added a commit
that referenced
this pull request
May 9, 2023
Go checks the pointers used, and it is required to follow the rule #5 of "unsafe.Pointer" which requires to convert back to "unsafe.Pointer" no later than in the same line where it was converted to uintptr.
xaionaro
added a commit
that referenced
this pull request
May 9, 2023
Go checks the pointers used, and it is required to follow the rule #5 of "unsafe.Pointer" which requires to convert back to "unsafe.Pointer" no later than in the same line where it was converted to uintptr.
xaionaro
added a commit
that referenced
this pull request
May 9, 2023
Go checks the pointers used, and it is required to follow the rule #5 of "unsafe.Pointer" which requires to convert back to "unsafe.Pointer" no later than in the same line where it was converted to uintptr.
xaionaro
added a commit
that referenced
this pull request
May 9, 2023
Go checks the pointers used, and it is required to follow the rule #5 of "unsafe.Pointer" which requires to convert back to "unsafe.Pointer" no later than in the same line where it was converted to uintptr.
xaionaro
added a commit
that referenced
this pull request
May 9, 2023
Go checks the pointers used, and it is required to follow the rule #5 of "unsafe.Pointer" which requires to convert back to "unsafe.Pointer" no later than in the same line where it was converted to uintptr. Signed-off-by: Dmitrii Okunev <xaionaro@meta.com>
xaionaro
added a commit
that referenced
this pull request
May 9, 2023
Go checks the pointers used, and it is required to follow the rule #5 of "unsafe.Pointer" which requires to convert back to "unsafe.Pointer" no later than in the same line where it was converted to uintptr. Signed-off-by: Dmitrii Okunev <xaionaro@meta.com>
xaionaro
added a commit
that referenced
this pull request
May 11, 2023
Go checks the pointers used, and it is required to follow the rule #5 of "unsafe.Pointer" which requires to convert back to "unsafe.Pointer" no later than in the same line where it was converted to uintptr. Signed-off-by: Dmitrii Okunev <xaionaro@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to do stuff like utk parse or utk extract in the future.