Skip to content

usb keyboard initialization is brocken #2101

@notgivenby

Description

@notgivenby

Basic details

A. Hardware Details

  1. Does your computer have a dGPU or is it iGPU-only?

    • dGPU (Distinct GPU other then internal GPU)
    • iGPU-only (Internal GPU, normally Intel GPU)
  2. Who installed Heads on this computer?

  3. What PGP key is being used?

    • Librem Key (Nitrokey Pro 2 rebranded)
    • Nitrokey Pro
    • Nitrokey Pro 2
    • Nitrokey 3 NFC
    • Nitrokey 3 NFC Mini
    • Nitrokey Storage
    • Nitrokey Storage 2
    • Yubikey
    • Other
  4. Are you using the PGP key to provide HOTP verification?

    • Yes
    • No
    • I don't know

B. Identify how the board was flashed

  1. Is this problem related to updating heads or flashing it for the first time?

    • First-time flash
    • Updating heads
  2. If the problem is related to an update, how did you attempt to apply the update?

    • Using the Heads menus
    • Flashrom via the Recovery Shell
    • External flashing
  3. How was Heads initially flashed?

    • External flashing
    • Internal-only / 1vyprep+1vyrain / skulls
    • Don't know
  4. Was the board flashed with a maximized or non-maximized/legacy rom?

    • Maximized
    • Non-maximized / legacy
    • I don't know
  5. If Heads was externally flashed, was IFD unlocked?

    • Yes
    • No
    • Don't know

C. Identify the rom related to this bug report

  1. Did you download or build the rom at issue in this bug report?

    • I downloaded it
    • I built it
  2. If you downloaded your rom, where did you get it from?

    • Heads CircleCi
    • Purism
    • Nitrokey
    • Dasharo DTS (Novacustom)
    • Somewhere else (please identify)
  3. If you built your rom, which repository:branch did you use?

  4. What version of Heads/coreboot are you running?
    (notgivenby@5c176b2)

  5. In building the rom, where did you get the blobs?

    • No blobs required
    • Provided by the company that installed Heads on the device
    • Extracted from a backup rom taken from this device
    • Extracted from another backup rom taken from another device (please identify the board model)
    • Extracted from the online bios using the automated tools provided in Heads
    • I don't know

The problem

Describe the bug
At the moment boards that only have a usb keyboard have a broken usb keyboard initialization during early boot.

In initrd/init, when CONFIG_USB_KEYBOARD_REQUIRED=y or CONFIG_USER_USB_KEYBOARD=y, the boot script only called ´´enable_usb´´´ function. This enabled USB support, but it did not load the ´´´usbhid.ko´´´ module needed for USB keyboard input. As a result, systems that depend on a USB keyboard during initrd/early boot end up without keyboard input.

To Reproduce
Steps to reproduce the behavior:

  1. Build EOL_x230-hotp-maximized_usb-kb
  2. Connect the usb keyboard
  3. No keyboard support although the Hardware key will work

Expected behavior
Working usb keyboard

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions