Skip to content

T480 linux config: add retpoline and USB OHCI HCD requirements for optional USB keyboard support (config menu enabled from ps/2 keyboard required)#2048

Merged
tlaurion merged 1 commit intolinuxboot:masterfrom
notgivenby:modify_linux_t480
Jan 28, 2026

Conversation

@notgivenby
Copy link
Copy Markdown
Contributor

This PR adds an enhancement against spectre. Moreover, it adds linux configs that are necessary to use HID usb keyboard. If the CONFIG_USB_KEYBOARD_REQUIRED=y without the lines the linux modules are not properly build which results in kernel panic. The issue was discovered during the port of m900_tiny board. notgivenby@adafc97

… external keyboard as per board config

Signed-off-by: notgivenby <notgivenby@gmail.com>
@tlaurion
Copy link
Copy Markdown
Collaborator

@notgivenby interesting discrepancies and unmeasured perf impact costs on expected fast execution of single user recovery shell tasks (mostly cryptsetup reencryption calls) which are not expected have any other multitasking when under GUI control flow.

I thought retpoline was desired to be off by design (it is something else for kexec'ed final OS considerations).

Either way, linux configs still varies on that matter:

grep -R RETPOLINE config/linux-*
config/linux-c216.config:CONFIG_RETPOLINE=y
config/linux-kgpe-d16_server.config:CONFIG_RETPOLINE=y
config/linux-kgpe-d16_server-whiptail.config:CONFIG_RETPOLINE=y
config/linux-kgpe-d16_workstation.config:CONFIG_RETPOLINE=y
config/linux-librem_common-6.1.8.config:# CONFIG_RETPOLINE is not set
config/linux-librem_common.config:CONFIG_RETPOLINE=y
config/linux-msi-z690-z790.config:# CONFIG_RETPOLINE is not set
config/linux-novacustom-common.config:CONFIG_RETPOLINE=y
config/linux-qemu.config:CONFIG_RETPOLINE=y
config/linux-t440p.config:CONFIG_RETPOLINE=y
config/linux-t480.config:# CONFIG_RETPOLINE is not set
config/linux-w541.config:CONFIG_RETPOLINE=y
config/linux-x230-flash.config:# CONFIG_RETPOLINE is not set
config/linux-x230-flash.config:CONFIG_RETPOLINE=y
config/linux-x230-legacy.config:CONFIG_RETPOLINE=y
config/linux-x230-maximized.config:CONFIG_RETPOLINE=y

TL:DR if goal is unifying configs and enforce same security policies across all boards, msi-z690-z790 and librem_l1um still put RETPOLINE off (x230-flash has it on and off but not supported anymore).

TBH @notgivenby, retpoline being on/off doesn't change much.
LGTM!

@tlaurion tlaurion changed the title modify linux config for t480 T480 Jan 26, 2026
@tlaurion tlaurion changed the title T480 T480 linux config: add retpoline and USB OHCI HCD requirements for optional USB keyboard support (config menu enabled from ps/2 keyboard required) Jan 26, 2026
@tlaurion tlaurion self-requested a review January 28, 2026 21:23
Copy link
Copy Markdown
Collaborator

@tlaurion tlaurion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merging

@tlaurion tlaurion merged commit 03b00ae into linuxboot:master Jan 28, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants