Skip to content

oem-factory-reset: improve firmware read UX and error logging #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlaurion merged 1 commit into from
Feb 23, 2026
Merged

oem-factory-reset: improve firmware read UX and error logging #2058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions initrd/bin/oem-factory-reset
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1375,8 +1375,16 @@ else
#We are not running in QEMU, so flash the key to ROM

## flash generated key to ROM
echo -e "\nReading current firmware...\n(this may take up to two minutes...)\n"
/bin/flash.sh -r /tmp/oem-setup.rom >/dev/null 2>/tmp/error
# read current firmware; show all output and capture stderr for errors
if echo "$CONFIG_FLASH_OPTIONS" | grep -q -- '--progress'; then
echo -e "\nReading current firmware (progress shown below)...\n"
else
echo -e "\nReading current firmware...\n(this may take up to two minutes...)\n"
fi
if ! /bin/flash.sh -r /tmp/oem-setup.rom 2> >(tee /tmp/error >&2); then
ERROR=$(tail -n 1 /tmp/error | fold -s)
whiptail_error_die "Error reading current firmware:\n\n$ERROR"
fi
if [ ! -s /tmp/oem-setup.rom ]; then
ERROR=$(tail -n 1 /tmp/error | fold -s)
whiptail_error_die "Error reading current firmware:\n\n$ERROR"
Expand Down