Conversation
Squashed from: tlaurion@2df1c8b tlaurion@447d464 then, updated EC revision as per: Dasharo/ec#82 (comment) Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Required to to build dasharo-ec module. Need to pin SDCC version to 4.2.0 to avoid Dasharo/dasharo-issues#1785 and be in sync with ec-sdk: Dasharo/ec-sdk#2 Using 3.8.0 in nix toolchain (as originally used in ec-sdk) was not feasible: linuxboot#2062 (comment) Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
…mal changes to build Dasharo-EC Signed-off-by: Thierry Laurion <insurgo@riseup.net>
site-local/config
Outdated
|
|
||
| ifeq "novacustom-v560tu" "$(BOARD)" | ||
|
|
||
| export CONFIG_COREBOOT_LOCALVERSION="\(coreboot+heads\) v0.9.1" |
| CONFIG_SOFTWARE_CONNECTION_MANAGER=y | ||
| CONFIG_SOC_INTEL_COMMON_BLOCK_VTD=y | ||
| CONFIG_ENABLE_EARLY_DMA_PROTECTION=y | ||
| # CONFIG_ENABLE_EARLY_DMA_PROTECTION is not set |
There was a problem hiding this comment.
not fixed by bumping fsp?
| CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y | ||
| CONFIG_LINEAR_FRAMEBUFFER=y | ||
| CONFIG_BOOTSPLASH=y | ||
| # CONFIG_BOOTSPLASH is not set |
There was a problem hiding this comment.
please review config from other pr
site-local/config
Outdated
| ifeq "novacustom-v560tu" "$(BOARD)" | ||
|
|
||
| export CONFIG_COREBOOT_LOCALVERSION="\(coreboot+heads\) v0.9.1" | ||
| export CONFIG_COREBOOT_SMBIOS_PRODUCT_NAME="V54x_6x_TU" |
There was a problem hiding this comment.
branding overrides (bootslash and site-local/config should be in dasharo fork not upstream
tlaurion
left a comment
There was a problem hiding this comment.
see review, most importantly bootsplash removal, site-local override and coreboot cojfigs in oldconfig which seem still uefi release oriented.
- Remove leading tabs from ifeq variable assignments (Make parse error) - Move post-build steps (cp, dd, touch) out of dasharo-ec_target into a proper Make rule; _target is now only make arguments - Set dasharo-ec_output to ec.rom (the actual artifact, not .built) - Add -$(BOARD) suffix to dasharo-ec_base_dir and dasharo-ec_dir so v540tu and v560tu maintain independent build trees and ec.rom files - Add explicit rule to copy and zero-pad ec.rom to 128 KB - Fix coreboot copy rule: use FORCE + cmp so the recipe always runs but only updates the destination (and its mtime) when content differs, preventing the mtime race between boards sharing coreboot_base_dir Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
…with make BOARD=X coreboot.save_in_oldconfig_format_in_place helper Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…with make BOARD=X coreboot.save_in_oldconfig_format_in_place helper Signed-off-by: Thierry Laurion <insurgo@riseup.net>
|
@filipleple please review commit logs of https://github.com/linuxboot/heads/pull/2039/commits One of those regression testing done in january 4th was f82d7e8 If not, we have a problem, we agreed on Clevo string back in #1913. We cannot change it otherwise internal flashing won't be possible. |
|
Please diff coreboot configs vs pre_release_dasharo_101_rc3 and explain/adapt:
|


This pull request updates the build configuration for NovaCustom V540TU and V560TU boards, focusing on switching from Clevo to NovaCustom mainboard definitions, updating the build environment, and aligning with the Dasharo EC and firmware stack. The changes improve consistency, bring in newer firmware components, and update several settings for hardware compatibility and feature support.
CI Environment Update:
.circleci/config.ymljobs fromtlaurion/heads-dev-env:v0.2.7tov0.2.9to ensure builds use the latest development environment. [1] [2] [3] [4]Board and Mainboard Configuration:
config/coreboot-novacustom-v540tu.config, and enabled the appropriate NovaCustom board options. This aligns the configuration with the actual hardware and firmware stack. [1] [2] [3] [4]CONFIG_DASHARO_EC=yto bothboards/novacustom-v540tu/novacustom-v540tu.configandboards/novacustom-v560tu/novacustom-v560tu.configto enable Dasharo EC support. [1] [2]Firmware and Embedded Controller:
v1.0.1, adjusted FSP paths and types, and enabled several new firmware and memory settings for improved hardware compatibility and debugging. [1] [2] [3] [4] [5] [6] [7] [8] [9]Feature and Peripheral Configuration:
These changes collectively modernize the firmware configuration for NovaCustom V540TU/V560TU, improve maintainability, and ensure compatibility with Dasharo EC and the latest coreboot features.