Skip to content

t480s: add p-state patch from https://review.coreboot.org/c/coreboot/+/91173#2121

Open
tlaurion wants to merge 1 commit into
linuxboot:masterfrom
tlaurion:t480_add_pstate
Open

t480s: add p-state patch from https://review.coreboot.org/c/coreboot/+/91173#2121
tlaurion wants to merge 1 commit into
linuxboot:masterfrom
tlaurion:t480_add_pstate

Conversation

@tlaurion
Copy link
Copy Markdown
Collaborator

Fix #2120

repro

cd ~
git clone https://github.com/linuxboot/heads
cd heads
./docker_repro.sh make BOARD=EOL_t480s-maximized
cd build/x86/coreboot-25.09/
git fetch https://review.coreboot.org/coreboot refs/changes/73/91173/2 && git format-patch -1 --stdout FETCH_HEAD > ../../../patches/coreboot-25.09/0013-sklkbl_thinkpad-Enable_ACPI_P-state_table_generation.patch
cd ~/heads
./docker_repro.sh make BOARD=EOL_t480s-maximized real.remove_canary_files-extract_patch_rebuild_what_changed
./docker_repro.sh make BOARD=EOL_t480s-maximized
[...]
INFO: Applying patch file: patches/coreboot-25.09/0013-sklkbl_thinkpad-Enable_ACPI_P-state_table_generation.patch
Checking patch build/x86/coreboot-25.09/src/mainboard/lenovo/sklkbl_thinkpad/devicetree.cb...
Applied patch build/x86/coreboot-25.09/src/mainboard/lenovo/sklkbl_thinkpad/devicetree.cb cleanly.
[...]

Please test artifacts @James333666999

…+/91173

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Copilot AI review requested due to automatic review settings May 17, 2026 17:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an upstream coreboot patch to the coreboot-25.09 patchset to enable ACPI P-state table generation on Lenovo sklkbl_thinkpad (fixing missing ACPI _PSS/_PCT/_PPC tables reported for T480s / issue #2120).

Changes:

  • Add coreboot patch 91173 to set eist_enable=true in src/mainboard/lenovo/sklkbl_thinkpad/devicetree.cb, enabling ACPI P-state table generation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +30 to +31
+ # Generate ACPI P-State table
+ register "eist_enable" = "true"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T480S Heads firmware lack ACPI P-state tables.

2 participants