config/coreboot-t420-maximized: align defconfig with cleaned defconfig pattern#2148
Merged
tlaurion merged 1 commit intoJul 1, 2026
Merged
Conversation
…g pattern - Disable CONFIG_USE_PC_CMOS_ALTCENTURY (coreboot default when !USE_OPTION_TABLE, no functional impact on Heads) - Disable CONFIG_RAMINIT_ENABLE_ECC (Sandy Bridge native raminit, laptop DIMMs are non-ECC) - Add CONFIG_DRIVERS_LENOVO_HYBRID_GRAPHICS for T420 Optimus support - Switch from USE_OPTION_TABLE to OPTION_BACKEND_NONE per project preference (Heads manages runtime config via initrd, not CMOS) - Sync config_defconfig to match current .config - Document full inconsistency audit across all coreboot configs in doc/variation-to-defconfig.md Signed-off-by: Thierry Laurion <insurgo@riseup.net>
tlaurion
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the Lenovo T420 “maximized” coreboot configuration to align defconfig with the current .config and the project’s preference for OPTION_BACKEND_NONE, while documenting a repo-wide audit of defconfig inconsistencies to prevent stale per-board drift.
Changes:
- Switch T420 maximized away from the CMOS option table (
USE_OPTION_TABLE) towardOPTION_BACKEND_NONEand clean related Kconfig toggles. - Disable ECC raminit and
USE_PC_CMOS_ALTCENTURYfor the T420 maximized configuration. - Expand
doc/variation-to-defconfig.mdwith an audit narrative and per-option board breakdowns.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| doc/variation-to-defconfig.md | Adds detailed audit documentation and summary counts for cross-board coreboot Kconfig inconsistencies. |
| config/coreboot-t420-maximized.config_defconfig | Cleans defconfig entries to match the current .config intent (ECC/CMOS options). |
| config/coreboot-t420-maximized.config | Switches option backend configuration and disables ECC raminit for this board. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ### CONFIG_USE_OPTION_TABLE | ||
|
|
||
| Total: **12 `=y`**, **35 `not set`** |
| ECC memory initialization. Most laptop DIMMs are non-ECC, so this is | ||
| typically harmless but useless. | ||
|
|
||
| Total: **14 `=y`**, **7 `not set`**, **34 absent** (non-native-raminit boards) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
t420-hotp-maximized's CBFS Free Space: 6372 bytes (6 KiB)
With those changes
Fixes #2147