gui-init: fix checking librem key card-status#682
Merged
tlaurion merged 1 commit intolinuxboot:masterfrom Feb 19, 2020
Merged
Conversation
Commit 6b5adcc moved the call to enable_usb from gui-init to init and guarded it with CONFIG_USB_KEYBOARD, but it was missed that this is needed for the clean boot check logic when a librem key is used. Add the call back to gui-init and guard it properly Test: clean_boot_detect works properly on a librem 13v4 Signed-off-by: Matt DeVillier <matt.devillier@puri.sm>
tlaurion
approved these changes
Feb 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 6b5adcc moved the call to enable_usb from gui-init
to init and guarded it with CONFIG_USB_KEYBOARD, but it was
missed that this is needed for the clean boot check logic
when a librem key is used. Add the call back to gui-init
and guard it properly
Test: clean_boot_detect works properly on a librem 13v4
Signed-off-by: Matt DeVillier matt.devillier@puri.sm