fix: 解决没有关机音效的问题#148
Merged
Merged
Conversation
因为用 Requisite= 是“硬依赖”。如果系统上没激活 sound.target(很多环境确实不会激活它),这个服务就不会在开机被拉起,结果就是 enabled 但一直 inactive (dead) Log: 去掉Requisite,改成Wants PMS: BUG-315787 Influence: 系统音效
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the deepin-shutdown-sound.service unit by changing its sound.target dependency from a hard ‘Requisite’ to a soft ‘Wants’, ensuring the service is pulled in even when sound.target isn’t explicitly activated. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来分析这个systemd服务文件的变更:
a) 语法逻辑:
b) 代码质量:
c) 代码性能:
d) 代码安全:
[Unit]
Description=Deepin shutdown sound service
DefaultDependencies=yes
Wants=sound.target local-fs.target
After=sound.target local-fs.target
Conflicts=shutdown.target
Before=shutdown.target
Type=simple这些改进使得服务文件更加清晰和完整,同时保持了原有的功能意图。主要改进包括:
|
robertkill
approved these changes
Aug 21, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
因为用 Requisite= 是“硬依赖”。如果系统上没激活 sound.target(很多环境确实不会激活它),这个服务就不会在开机被拉起,结果就是 enabled 但一直 inactive (dead)
Log: 去掉Requisite,改成Wants
PMS: BUG-315787
Influence: 系统音效
Summary by Sourcery
Bug Fixes: