fix: add audio group permission to login and shutdown sound services

[wyu71]

• Added SupplementaryGroups=audio to ensure proper audio device access for login and shutdown sounds

Log: add audio group permission to login and shutdown sound services
pms: BUG-333303

Summary by Sourcery

Add audio group permission to login and shutdown sound services

Bug Fixes:

• Add SupplementaryGroups=audio to deepin-login-sound.service to grant audio device access
• Add SupplementaryGroups=audio to deepin-shutdown-sound.service to grant audio device access

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

deepin pr auto review

我来分析这个git diff的内容，这是一个systemd服务单元文件的修改，主要涉及两个服务：deepin-login-sound.service和deepin-shutdown-sound.service。

语法逻辑分析

1. 两个服务文件都添加了SupplementaryGroups=audio行，这是正确的语法，表示将deepin-daemon用户添加到audio辅助组。
2. 文件结构符合systemd服务单元文件的规范，包括[Unit]、[Service]等标准段落。

代码质量分析

1. 添加SupplementaryGroups=audio是一个很好的改进，这样deepin-daemon用户就可以访问音频设备而不需要直接是audio组的成员。
2. 保持了原有的服务配置不变，只添加了必要的组权限设置，符合最小权限原则。

代码性能分析

1. 这个修改不会对性能产生明显影响，只是在用户启动时添加了组 membership。
2. 使用SupplementaryGroups而不是直接将用户加入audio组，更加灵活且不会影响系统的其他部分。

代码安全分析

1. 这是一个安全改进，因为：
   • 不需要将deepin-daemon用户直接添加到audio主组，减少了潜在的安全风险
   • 使用SupplementaryGroups提供了更细粒度的权限控制
   • 遵循了最小权限原则

改进建议

1. 考虑添加Group=audio而不是SupplementaryGroups=audio，因为这样更明确地表明服务需要音频组权限。
2. 可以考虑添加ProtectSystem=strict和PrivateTmp=true等选项进一步增强安全性。
3. 对于deepin-shutdown-sound.service，可以考虑添加TimeoutStopSec以确保服务能够及时关闭。
4. 建议在服务描述中明确说明需要audio组权限的原因，这样其他开发者更容易理解配置的必要性。

总体而言，这个修改是一个合理的权限调整，提高了系统的安全性，同时保持了服务的正常功能。

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Add SupplementaryGroups=audio to the login and shutdown sound unit files, ensuring these services run with audio group privileges for proper device access.

File-Level Changes

Change	Details	Files
Grant audio group permission to login sound service	Add SupplementaryGroups=audio directive under [Service]	misc/systemd/system/deepin-login-sound.service
Grant audio group permission to shutdown sound service	Add SupplementaryGroups=audio directive under [Service]	misc/systemd/system/deepin-shutdown-sound.service

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, wyu71

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wyu71]

/forcemerge