chore: remove deprecated theme and thumbnail modules #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Removed cursor-helper DBus service and related files 2. Removed theme_thumb module for generating theme previews 3. Removed themes module for theme management and scanning 4. Removed thumbnails module for file thumbnail generation 5. Removed thumbnailer binary 6. Updated Makefile to exclude removed components from build 7. These modules have been migrated to other repositories or are no longer needed Influence: 1. Verify build completes successfully without removed components 2. Test remaining functionality in the API package 3. Ensure no dependencies on removed modules in other packages 4. Check that system theme management still works through other services 5. Confirm file thumbnail generation is handled by other components chore: 移除已弃用的主题和缩略图模块 1. 移除 cursor-helper DBus 服务及相关文件 2. 移除用于生成主题预览的 theme_thumb 模块 3. 移除用于主题管理和扫描的 themes 模块 4. 移除用于文件缩略图生成的 thumbnails 模块 5. 移除 thumbnailer 二进制文件 6. 更新 Makefile 从构建中排除已移除的组件 7. 这些模块已迁移到其他仓库或不再需要 Influence: 1. 验证构建在没有移除组件的情况下成功完成 2. 测试 API 包中剩余的功能 3. 确保其他包不依赖已移除的模块 4. 检查系统主题管理是否仍通过其他服务正常工作 5. 确认文件缩略图生成由其他组件处理
Contributor
Author
|
这些模块已经迁移至 dde-appearance |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis pull request removes several deprecated theme and thumbnail-related modules (cursor-helper DBus service, theme_thumb, themes, thumbnails, and thumbnailer) and updates the build configuration to stop building and testing them. Flow diagram for updated build configuration without deprecated modulesflowchart LR
A["Developer runs make"] --> B["Load Makefile"]
B --> C["Resolve TESTS list"]
C --> C1["Run Go tests for remaining modules"]
%% Previously included tests (now removed)
C -.skipped.-> T1["cursor-helper tests (removed)"]
C -.skipped.-> T2["theme_thumb tests (removed)"]
C -.skipped.-> T3["themes tests (removed)"]
C -.skipped.-> T4["thumbnailer tests (removed)"]
C -.skipped.-> T5["thumbnails tests (removed)"]
C1 --> D["Resolve LIBRARIES list"]
D --> D1["Build remaining libraries"]
%% Previously built libraries (now removed)
D -.skipped.-> L1["thumbnails library (removed)"]
D -.skipped.-> L2["themes library (removed)"]
D -.skipped.-> L3["theme_thumb library (removed)"]
D1 --> E["Resolve BINARIES list"]
E --> E1["Build remaining binaries"]
%% Previously built binaries (now removed)
E -.skipped.-> B1["thumbnailer binary (removed)"]
E -.skipped.-> B2["cursor-helper binary (removed)"]
E1 --> F["Install or package artifacts"]
classDef skipped stroke:#ff0000,color:#ff0000;
class T1,T2,T3,T4,T5,L1,L2,L3,B1,B2 skipped;
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since the DBus service, binaries, and libraries are removed, scan the repo for remaining references to
cursor-helper,thumbnailer,thumbnails,themes, andtheme_thumb(e.g., in other Makefile targets, init/service configs, or code) and clean up any leftovers to avoid build-time or runtime confusion. - Consider also pruning any now-unused build artifacts or install rules related to the removed modules (e.g., installation paths,
install-*targets, or generated files tied to those components) so the Makefile accurately reflects the current set of deliverables.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the DBus service, binaries, and libraries are removed, scan the repo for remaining references to `cursor-helper`, `thumbnailer`, `thumbnails`, `themes`, and `theme_thumb` (e.g., in other Makefile targets, init/service configs, or code) and clean up any leftovers to avoid build-time or runtime confusion.
- Consider also pruning any now-unused build artifacts or install rules related to the removed modules (e.g., installation paths, `install-*` targets, or generated files tied to those components) so the Makefile accurately reflects the current set of deliverables.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review我来帮你分析这个git diff。这个diff主要删除了与cursor(鼠标指针)、theme(主题)和thumbnail(缩略图)相关的代码文件。让我从几个方面来分析：
改进建议：
总的来说，这次删除操作在技术上是合理的，但需要确保有充分的业务理由，并且已经做好了相应的替代或迁移方案。建议在后续开发中密切关注这些功能模块的替代实现。 |
fly602
approved these changes
Dec 25, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Influence:
chore: 移除已弃用的主题和缩略图模块
Influence:
Summary by Sourcery
Remove deprecated theme and thumbnail-related modules and binaries from the project and update the build configuration accordingly.
Enhancements: