fix: display banner notification after changing scale

[52cyb]

After clicking the 'Later' button to turn off the scale notification, reset the replaceId of the notification so that the scale notification can be triggered when the scale is changed again

点击“稍后注销”按钮关闭缩放通知后，重置对应通知的replaceId，使得再次更改缩放后可以触发通知

Log: 点击“稍后注销”按钮关闭缩放通知后，重置对应通知的replaceId
PMS: BUG-358697
Influence: 缩放通知关闭后，再次更改缩放后可以触发通知

Summary by Sourcery

Bug Fixes:

• Fix scale change banner not reappearing after the user dismisses it once by resetting the stored notification ID when the notification is closed.

[deepin-ci-robot]

Hi @52cyb. Thanks for your PR. 😃

[deepin-ci-robot]

Hi @52cyb. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Connects to the org.freedesktop.Notifications DBus NotificationClosed signal and resets the stored notification ID when the corresponding scale notification is closed, allowing a new banner to be shown after scale changes again.

Sequence diagram for notification reset after scale change

sequenceDiagram
    actor User
    participant DisplayService as org_deepin_dde_Display1
    participant AppearanceProxy as AppearanceDBusProxy
    participant NotifyService as org_freedesktop_Notifications

    User->>DisplayService: Change display scale
    DisplayService-->>AppearanceProxy: PropertiesChanged
    AppearanceProxy->>NotifyService: Notify scale_change_banner(m_nid)

    User->>NotifyService: Click Later button
    NotifyService-->>AppearanceProxy: NotificationClosed(id, reason)
    AppearanceProxy->>AppearanceProxy: onNotificationClosed(id, reason)
    AppearanceProxy->>AppearanceProxy: if id == m_nid then m_nid = 0

    User->>DisplayService: Change display scale again
    DisplayService-->>AppearanceProxy: PropertiesChanged
    AppearanceProxy->>NotifyService: Notify new scale_change_banner(m_nid)

Loading

Updated class diagram for AppearanceDBusProxy notification handling

classDiagram
    class AppearanceDBusProxy {
        +AppearanceDBusProxy(QObject *parent)
        +void setUserInterface(QString userPath)
        <<slots>>
        -void onDisplayPropertiesChanged(QDBusMessage message)
        -void onNotificationClosed(uint id, uint reason)
        -- attributes --
        -DDBusInterface *m_wmInterface
        -uint m_nid
    }

Loading

File-Level Changes

Change	Details	Files
Handle notification closure to allow re-showing the scale change banner	Add a DBus signal connection to org.freedesktop.Notifications.NotificationClosed in the AppearanceDBusProxy constructor Introduce a new private slot onNotificationClosed that receives the notification ID and closure reason Reset the stored notification ID member to 0 when the closed notification matches the tracked ID	src/service/dbus/appearancedbusproxy.cpp src/service/dbus/appearancedbusproxy.h

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 52cyb, mhduiy

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[52cyb]

/merge