Skip to content

fix: restore disabled port notification when replugging device#1100

Open
52cyb wants to merge 1 commit intolinuxdeepin:masterfrom
52cyb:master
Open

fix: restore disabled port notification when replugging device#1100
52cyb wants to merge 1 commit intolinuxdeepin:masterfrom
52cyb:master

Conversation

@52cyb
Copy link
Copy Markdown

@52cyb 52cyb commented May 9, 2026

Move the first == nil guard so it no longer blocks the port disabled notification logic in the else branch of doDiff.

调整判断逻辑,以触发禁用设备的通知

Log: restore disabled port notification
PMS: BUG-358907
Influence: 重新插拔已经禁用的输出设备,是否正确弹出启用通知

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @52cyb, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 52cyb

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Copy Markdown

Hi @52cyb. Thanks for your PR. 😃

Move the `first == nil` guard so it no longer blocks the port disabled
notification logic in the else branch of doDiff.

调整判断逻辑,以触发禁用设备的通知

Log: restore disabled port notification
PMS: BUG-358907
Influence: 重新插拔已经禁用的输出设备,是否正确弹出启用通知
@deepin-ci-robot
Copy link
Copy Markdown

Hi @52cyb. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants