fix: Apply the list module text color and hover effect adjustments#552
Conversation
There was a problem hiding this comment.
Hey @wjyrich - I've reviewed your changes - here's some feedback:
- The text color hover logic is duplicated; consider centralizing this behavior for
AppListView.qmlandFreeSortListView.qml. - In
AppListView.qml, the base text color source changed fromListView.view.palette.brightTexttoparent.palette.brightText; please verify this was intended. - Consider using
Qt.alpha(color, alphaValue)for a more concise way to set color opacity instead of reconstructing it withQt.rgba().
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Reviewer's GuideThis PR implements dynamic text opacity for list items in File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
update when hovered, app palette from 70% to 100% pms-bug-314399
deepin pr auto review代码审查意见:
综上所述,建议对重复代码进行提取,处理 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
update when hovered, app palette from 70% to 100%
pms-bug-314399
Summary by Sourcery
Adjust text color opacity for list module items to improve visual appearance
Bug Fixes:
Enhancements: