fix: add x-dde-dock-dnd-source for dde-dock#556
Conversation
when drag app from laucher to dock can be classified. Log: updateDragSource
deepin pr auto review在提供的代码更改中,主要添加了一行代码,用于在 代码质量
代码性能
代码安全
其他建议
总的来说,这个更改看起来是一个小的、合理的添加,但建议进行一些额外的检查和测试以确保代码的质量、性能和安全性。 |
Reviewer's GuideThis pull request updates the drag-and-drop data by adding a new MIME type, "text/x-dde-dock-dnd-source", to specify that the drag operation originated from the launcher. This is done within the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @wjyrich - I've reviewed your changes - here's some feedback:
- If
Helper.qmlis used by drag sources other than the launcher, the 'dnd-source' value should be dynamic rather than hardcoded as 'launcher'.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
when drag app from laucher to dock can be classified.
Log: updateDragSource
Summary by Sourcery
Enhancements: