Skip to content

chore: release dde-launchpad 1.99.14#559

Merged
BLumia merged 1 commit into
linuxdeepin:masterfrom
wjyrich:release/1.99.14
May 13, 2025
Merged

chore: release dde-launchpad 1.99.14#559
BLumia merged 1 commit into
linuxdeepin:masterfrom
wjyrich:release/1.99.14

Conversation

@wjyrich
Copy link
Copy Markdown
Contributor

@wjyrich wjyrich commented May 13, 2025

fix: Dragging applications in application folder cannot create a new page (Bug-288839)
fix: add x-dde-dock-dnd-source for dde-dock.
fix: cancel hovered state after move mouse in the categorized display. (Bug-271375)

Log: release dde-launchpad 1.99.14

Summary by Sourcery

Release dde-launchpad 1.99.14 with several bug fixes and a version bump.

Bug Fixes:

  • Allow dragging applications in the application folder to create a new page.
  • Add x-dde-dock-dnd-source support to dde-dock.
  • Reset hovered state when moving the mouse in the categorized display.

Chores:

  • Bump dde-launchpad version to 1.99.14.

fix: Dragging applications in application folder cannot create a new page (Bug-288839)
fix: add x-dde-dock-dnd-source for dde-dock.
fix: cancel hovered state after move mouse in the categorized display. (Bug-271375)

Log: release dde-launchpad 1.99.14
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 13, 2025

Reviewer's Guide

Updates the Debian packaging metadata by adding a new changelog entry for version 1.99.14 that documents three bug fixes.

File-Level Changes

Change Details Files
Add new release entry in debian/changelog
  • Bump version to 1.99.14
  • Describe fix for dragging apps not creating a new page
  • Describe addition of x-dde-dock-dnd-source in dde-dock
  • Describe fix for hover-state cancellation in categorized display
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

这个提交的changelog文件更新了dde-launchpad的版本号,并记录了三个修复的bug。总体来说,这个提交是合理的,但有一些地方可以进一步优化:

  1. 版本号格式:在changelog文件中,版本号1.99.14的格式看起来有些不寻常。通常,版本号会遵循主版本号.次版本号.修订号的格式,例如1.99.14。确保版本号遵循标准的语义化版本控制(Semantic Versioning)。

  2. 日期格式:提交日期Tue, 13 May 2025 17:17:000 +0800中的时间部分000可能是一个错误,应该是00。确保日期和时间格式正确。

  3. 描述格式:在changelog中,每个修复的bug都应该有一个简短的描述,并且应该使用中文。例如,fix: Dragging applications in application folder cannot create a new page (Bug-288839)中的描述可以更详细一些,比如修复:在应用程序文件夹中拖动应用程序无法创建新页面 (Bug-288839)

  4. 提交信息格式:提交信息应该遵循一定的格式,以便于其他开发者理解。通常,提交信息包括一个简短的标题和更详细的描述。例如:

    dde-launchpad (1.99.14) UNRELEASED; urgency=medium
    
      * 修复:在应用程序文件夹中拖动应用程序无法创建新页面 (Bug-288839)
      * 修复:添加 x-dde-dock-dnd-source 以支持 dde-dock 的拖放操作。
      * 修复:在分类显示中移动鼠标后取消悬停状态 (Bug-271375)
    
    -- Wu Jiangyu <wujiangyu@uniontech.com>  2025-05-13 17:17:00 +0800
    

    这样可以更清晰地表达修复的内容和目的。

  5. 版本号更新:在changelog文件中,版本号从1.99.13更新到1.99.14,确保这个版本号的更新是合理的,并且与实际修复的bug相关。

综上所述,这个提交的changelog文件在格式和内容上可以进一步优化,以提高代码的可读性和维护性。

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wjyrich - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link
Copy Markdown

TAG Bot

TAG: 1.99.14
EXISTED: no
DISTRIBUTION: UNRELEASED

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 370a535 into linuxdeepin:master May 13, 2025
8 of 11 checks passed
@wjyrich wjyrich deleted the release/1.99.14 branch June 6, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants