Skip to content

chore: Modify compilation issues#357

Merged
caixr23 merged 1 commit intolinuxdeepin:masterfrom
caixr23:master
Jun 13, 2025
Merged

chore: Modify compilation issues#357
caixr23 merged 1 commit intolinuxdeepin:masterfrom
caixr23:master

Conversation

@caixr23
Copy link
Copy Markdown
Contributor

@caixr23 caixr23 commented Jun 13, 2025

Modify compilation issues

Summary by Sourcery

Build:

  • Add CMAKE_THREAD_LIBS_INIT, CMAKE_HAVE_THREADS_LIBRARY, CMAKE_USE_PTHREADS_INIT, and CMAKE_PREFER_PTHREAD_FLAG to CMakeLists in network-service, dcc-network, dock-network, and dss-network plugins to enforce pthread linking.

Modify compilation issues
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 13, 2025

Reviewer's Guide

This PR resolves compilation/linking issues by explicitly configuring pthread support in each network plugin’s CMakeLists, ensuring the thread library is correctly detected and linked.

File-Level Changes

Change Details Files
Introduce explicit pthread configuration in CMakeLists for all network plugins
  • Initialize CMAKE_THREAD_LIBS_INIT with "-lpthread"
  • Set CMAKE_HAVE_THREADS_LIBRARY to 1
  • Enable CMAKE_USE_PTHREADS_INIT
  • Enable CMAKE_PREFER_PTHREAD_FLAG
network-service-plugin/CMakeLists.txt
dcc-network/CMakeLists.txt
dock-network-plugin/CMakeLists.txt
dss-network-plugin/CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23 caixr23 merged commit 629e57e into linuxdeepin:master Jun 13, 2025
15 of 17 checks passed
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @caixr23 - I've reviewed your changes - here's some feedback:

  • Use find_package(Threads) and link against Threads::Threads instead of manually setting CMAKE_THREAD_LIBS_INIT and related variables.
  • Factor out the repeated thread‐setup block into a shared CMake include or macro to avoid duplication across each plugin's CMakeLists.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Use find_package(Threads) and link against Threads::Threads instead of manually setting CMAKE_THREAD_LIBS_INIT and related variables.
- Factor out the repeated thread‐setup block into a shared CMake include or macro to avoid duplication across each plugin's CMakeLists.

## Individual Comments

### Comment 1
<location> `network-service-plugin/CMakeLists.txt:24` </location>
<code_context>

 project(${PLUGIN_NAME})

+set(CMAKE_THREAD_LIBS_INIT "-lpthread")
+set(CMAKE_HAVE_THREADS_LIBRARY 1)
+set(CMAKE_USE_PTHREADS_INIT 1)
+set(CMAKE_PREFER_PTHREAD_FLAG ON)
+
 set(CMAKE_CXX_STANDARD 17)
</code_context>

<issue_to_address>
Consider centralizing this logic and using modern CMake for threading.

This code is duplicated across four `CMakeLists.txt` files; consider moving it to a shared CMake file and including it where needed. Also, prefer `find_package(Threads REQUIRED)` and linking `Threads::Threads` for better portability and modern CMake practices.

Suggested implementation:

```
include(cmake/ThreadsConfig.cmake)

```

1. Create a shared file at `cmake/ThreadsConfig.cmake` with the following content:
   ```
   find_package(Threads REQUIRED)
   ```
2. In this `CMakeLists.txt`, ensure that your target (e.g., `target_link_libraries(your_target PRIVATE Threads::Threads)`) is linked to `Threads::Threads`.
3. Repeat the `include(cmake/ThreadsConfig.cmake)` and `target_link_libraries(... Threads::Threads)` in the other three `CMakeLists.txt` files as needed.
4. Adjust the path to `ThreadsConfig.cmake` if your project structure differs.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +24 to +27
set(CMAKE_THREAD_LIBS_INIT "-lpthread")
set(CMAKE_HAVE_THREADS_LIBRARY 1)
set(CMAKE_USE_PTHREADS_INIT 1)
set(CMAKE_PREFER_PTHREAD_FLAG ON)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider centralizing this logic and using modern CMake for threading.

This code is duplicated across four CMakeLists.txt files; consider moving it to a shared CMake file and including it where needed. Also, prefer find_package(Threads REQUIRED) and linking Threads::Threads for better portability and modern CMake practices.

Suggested implementation:

include(cmake/ThreadsConfig.cmake)

  1. Create a shared file at cmake/ThreadsConfig.cmake with the following content:
    find_package(Threads REQUIRED)
    
  2. In this CMakeLists.txt, ensure that your target (e.g., target_link_libraries(your_target PRIVATE Threads::Threads)) is linked to Threads::Threads.
  3. Repeat the include(cmake/ThreadsConfig.cmake) and target_link_libraries(... Threads::Threads) in the other three CMakeLists.txt files as needed.
  4. Adjust the path to ThreadsConfig.cmake if your project structure differs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants