Skip to content

fix: in quick login mode, the dde-version-check is executed only afte…#168

Merged
yixinshark merged 1 commit intolinuxdeepin:masterfrom
yixinshark:fix-welcome
Nov 10, 2025
Merged

fix: in quick login mode, the dde-version-check is executed only afte…#168
yixinshark merged 1 commit intolinuxdeepin:masterfrom
yixinshark:fix-welcome

Conversation

@yixinshark
Copy link
Copy Markdown
Contributor

@yixinshark yixinshark commented Nov 7, 2025

…r the lock is unlocked

in normal mode, the dde-version-check is executed in initialized phase

Log: as title
Pms: BUG-321889

Summary by Sourcery

Fix the timing of the dde-version-check in quick login sessions by introducing a new systemd template service that only runs after unlocking and updating install rules accordingly

Bug Fixes:

  • Ensure the version checker in quick login mode only executes after session unlock

Enhancements:

  • Add dde-version-checker@quick-login.service unit to delay execution in quick login
  • Update CMakeLists to install the quick-login service without auto-enabling it and preserve auto-start for the normal service

…r the lock is unlocked

in normal mode, the dde-version-check is executed in initialized phase

Log: as title
Pms: BUG-321889
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Nov 7, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduce a dedicated quick-login variant for the dde-version-checker service and adjust installation logic so only the normal mode service is auto-enabled at session initialization while the quick-login version runs later after unlock.

Class diagram for new dde-version-checker@quick-login.service addition

classDiagram
  class dde_version_checker_service {
    +Runs in normal mode
    +Enabled at session initialization
  }
  class dde_version_checker_quick_login_service {
    +Runs in quick-login mode
    +Activated after unlock
    -Not auto-enabled at session initialization
  }
  dde_version_checker_quick_login_service --|> dde_version_checker_service : variant
Loading

File-Level Changes

Change Details Files
Add quick-login template service for version checking tools/dde-version-checker/CMakeLists.txt
tools/dde-version-checker/dde-version-checker@quick-login.service
Modify installation to auto-start only the normal service
  • Keep symlink creation for dde-version-checker.service only
  • Exclude quick-login template from dde-session-initialized.target.wants
  • Update comments to clarify startup behavior per mode
tools/dde-version-checker/CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark merged commit f83f5cd into linuxdeepin:master Nov 10, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants